fix: no tenant cache for run migrations event#957
Merged
ferhatelmas merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR ensures the “run migrations” queue event does not rely on potentially stale in-memory tenant configuration by explicitly clearing the tenant config cache before loading the tenant config from the multitenant DB.
Changes:
- Clear the in-memory tenant config cache at the start of
RunMigrationsOnTenants.handle()before callinggetTenantConfig(). - Extend the corresponding test to assert the cache invalidation call happens before the config is fetched.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/storage/events/migrations/run-migrations.ts | Clears tenant config cache prior to fetching config for migrations execution. |
| src/test/run-migrations-event.test.ts | Adds assertions verifying deleteTenantConfig() is called and precedes getTenantConfig(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 23838572089Details
💛 - Coveralls |
Member
Author
|
This was just hardening becauase cache is always supposed to be up to date. If not, we have bigger issues.
We decided to take it since it's a small nice to have. |
fenos
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Run migrations event uses a cached config.
What is the new behavior?
Event uses a fresh copy by loading from db.
Additional context
Cached value could be with stale config.