Skip to content

fix: use correct ErrorCode values for InvalidParameter, FeatureNotEnabled, and NotSupported#986

Merged
ferhatelmas merged 1 commit intosupabase:masterfrom
oniani1:fix/error-code-mismatches
Apr 7, 2026
Merged

fix: use correct ErrorCode values for InvalidParameter, FeatureNotEnabled, and NotSupported#986
ferhatelmas merged 1 commit intosupabase:masterfrom
oniani1:fix/error-code-mismatches

Conversation

@oniani1
Copy link
Copy Markdown
Contributor

@oniani1 oniani1 commented Apr 6, 2026

Fixes #983

Three error factory functions use the wrong ErrorCode enum value:

  • ERRORS.InvalidParameter used ErrorCode.MissingParameter (affects 18+ call sites)
  • ERRORS.FeatureNotEnabled used ErrorCode.InvalidRequest (affects 28+ call sites)
  • ERRORS.NotSupported used ErrorCode.InvalidRequest (affects 1 call site)

All three correct enum values already exist but were never referenced. One-line fix each.

@oniani1 oniani1 requested a review from a team as a code owner April 6, 2026 18:58
@ferhatelmas ferhatelmas force-pushed the fix/error-code-mismatches branch from 0590238 to 0e6712d Compare April 7, 2026 09:05
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24073438616

Coverage decreased (-0.002%) to 80.664%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (1 of 3 lines covered, 33.33%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/internal/errors/codes.ts 3 1 33.33%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37229
Covered Lines: 30214
Line Coverage: 81.16%
Relevant Branches: 4113
Covered Branches: 3134
Branch Coverage: 76.2%
Branches in Coverage %: Yes
Coverage Strength: 314.52 hits per line

💛 - Coveralls

@ferhatelmas ferhatelmas merged commit 126295b into supabase:master Apr 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error factories use wrong ErrorCode values (InvalidParameter, FeatureNotEnabled, NotSupported)

3 participants