Skip to content

fix: add regression tests for checksums#988

Merged
ferhatelmas merged 1 commit intomasterfrom
ferhat/reg1
Apr 7, 2026
Merged

fix: add regression tests for checksums#988
ferhatelmas merged 1 commit intomasterfrom
ferhat/reg1

Conversation

@ferhatelmas
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Tests

What is the current behavior?

No coverage for fixes in #984

What is the new behavior?

Some coverage to prevent regression.

Additional context

#982

Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Copilot AI review requested due to automatic review settings April 7, 2026 08:23
@ferhatelmas ferhatelmas requested a review from a team as a code owner April 7, 2026 08:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds targeted regression tests to prevent reintroducing previously fixed S3 multipart checksum mapping and missing-parameter reporting issues (from #984 / #982), improving confidence in the S3 protocol/router behavior.

Changes:

  • Adds a test verifying the Iceberg CompleteMultipartUpload route maps ChecksumCRC32C from the backend response to the correct response field.
  • Adds a test verifying S3ProtocolHandler.completeMultiPartUpload() preserves ChecksumCRC32C in its response mapping.
  • Adds tests ensuring headObject and dbHeadObject report Key (not Bucket) as the missing parameter when Key is absent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24071766404

Coverage increased (+0.1%) to 80.664%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37229
Covered Lines: 30214
Line Coverage: 81.16%
Relevant Branches: 4113
Covered Branches: 3134
Branch Coverage: 76.2%
Branches in Coverage %: Yes
Coverage Strength: 314.52 hits per line

💛 - Coveralls

@ferhatelmas ferhatelmas merged commit 77271c1 into master Apr 7, 2026
9 checks passed
@ferhatelmas ferhatelmas deleted the ferhat/reg1 branch April 7, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants