fix: add regression tests for checksums#988
Merged
ferhatelmas merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds targeted regression tests to prevent reintroducing previously fixed S3 multipart checksum mapping and missing-parameter reporting issues (from #984 / #982), improving confidence in the S3 protocol/router behavior.
Changes:
- Adds a test verifying the Iceberg
CompleteMultipartUploadroute mapsChecksumCRC32Cfrom the backend response to the correct response field. - Adds a test verifying
S3ProtocolHandler.completeMultiPartUpload()preservesChecksumCRC32Cin its response mapping. - Adds tests ensuring
headObjectanddbHeadObjectreportKey(notBucket) as the missing parameter whenKeyis absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fenos
approved these changes
Apr 7, 2026
Coverage Report for CI Build 24071766404Coverage increased (+0.1%) to 80.664%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests
What is the current behavior?
No coverage for fixes in #984
What is the new behavior?
Some coverage to prevent regression.
Additional context
#982