Skip to content
This repository was archived by the owner on May 13, 2023. It is now read-only.

Conversation

@DanMossa
Copy link
Contributor

It's helpful to specify the type when using subscriptions.

@DanMossa DanMossa changed the title Export type SupabaseRealtimePayload chore: 0.3.5 : Export type SupabaseRealtimePayload May 31, 2022
@DanMossa DanMossa changed the title chore: 0.3.5 : Export type SupabaseRealtimePayload chore: 0.3.4+1 : Export type SupabaseRealtimePayload May 31, 2022
@dshukertjr
Copy link
Member

Nice one @DanMossa !

It seems like we are getting some analysis error with it. Could you check it out?

@DanMossa
Copy link
Contributor Author

DanMossa commented Jun 1, 2022

Bizarre. Tests are failing but I'm unable to get the same error when I run the test locally. Are you also getting failing tests when you run them locally?

@dshukertjr
Copy link
Member

@DanMossa Actually, the tests have been very flaky lately. I was going to work on a fix at some point, but haven't been able to do so yet. After rerunning it a few times, it usually passes.

I will rerun the tests and if they pass, I will go ahead and merge this PR!

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the amazing work!

@dshukertjr dshukertjr merged commit 0d5366a into supabase:main Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants