fix(gotrue): allow refreshSession with refreshToken when no current session exists #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1261
This PR removes the redundant check that required
currentSession.accessTokento exist before allowing a session refresh.Problem
The
refreshSessionmethod was throwing anAuthSessionMissingExceptionwhen there was no current session, even if a validrefreshTokenwas provided as a parameter. This blocked a valid use case where you might have a refresh token but no current session.Solution
currentSession?.accessToken == nullcurrentSessionRefreshToken == null) is sufficient to handle both cases:refreshTokenparameter is provided_currentSession?.refreshTokenChanges
packages/gotrue/lib/src/gotrue_client.dart: Removed redundant check, updated docspackages/gotrue/test/client_test.dart: Added test for refreshSession with refreshToken when no current session existsTesting
refreshSession(refreshToken)works whencurrentSessionis null