Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/realtime_client/lib/src/message.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ class Message {
final String topic;
final ChannelEvents event;
final dynamic payload;
final String ref;
final String? ref;
final String? joinRef;

Message({
required this.topic,
required this.event,
required this.payload,
required this.ref,
this.ref,
this.joinRef,
});

Expand Down Expand Up @@ -48,7 +48,7 @@ class Message {
'event':
event != ChannelEvents.heartbeat ? event.eventName() : 'heartbeat',
'payload': processedPayload,
'ref': ref,
if (ref != null) 'ref': ref,
if (joinRef != null) 'join_ref': joinRef,
};
}
Expand Down
94 changes: 94 additions & 0 deletions packages/realtime_client/test/message_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import 'package:realtime_client/src/constants.dart';
import 'package:realtime_client/src/message.dart';
import 'package:test/test.dart';

void main() {
group('Message', () {
test('message with null refs serializes correctly', () {
final message = Message(
topic: 'phoenix',
event: ChannelEvents.heartbeat,
payload: {},
ref: null,
joinRef: null,
);
final json = message.toJson();
expect(json['ref'], isNull);
expect(json['join_ref'], isNull);
expect(json['topic'], equals('phoenix'));
expect(json['event'], equals('heartbeat'));
expect(json['payload'], equals({}));
});

test('heartbeat message with null joinRef', () {
final message = Message(
topic: 'phoenix',
event: ChannelEvents.heartbeat,
payload: {},
ref: '123',
joinRef: null,
);
final json = message.toJson();
expect(json['ref'], equals('123'));
expect(json.containsKey('join_ref'), isFalse);
expect(json['topic'], equals('phoenix'));
expect(json['event'], equals('heartbeat'));
});

test('message with null ref but valid joinRef', () {
final message = Message(
topic: 'room:lobby',
event: ChannelEvents.join,
payload: {'user_id': '123'},
ref: null,
joinRef: 'join-456',
);
final json = message.toJson();
expect(json.containsKey('ref'), isFalse);
expect(json['join_ref'], equals('join-456'));
expect(json['topic'], equals('room:lobby'));
expect(json['payload'], equals({'user_id': '123'}));
});

test('message with both ref and joinRef', () {
final message = Message(
topic: 'room:lobby',
event: ChannelEvents.join,
payload: {'user_id': '123'},
ref: 'ref-789',
joinRef: 'join-456',
);
final json = message.toJson();
expect(json['ref'], equals('ref-789'));
expect(json['join_ref'], equals('join-456'));
expect(json['topic'], equals('room:lobby'));
expect(json['payload'], equals({'user_id': '123'}));
});

test('message with ref but null joinRef', () {
final message = Message(
topic: 'room:lobby',
event: ChannelEvents.leave,
payload: {},
ref: 'ref-999',
joinRef: null,
);
final json = message.toJson();
expect(json['ref'], equals('ref-999'));
expect(json.containsKey('join_ref'), isFalse);
expect(json['topic'], equals('room:lobby'));
});

test('ref parameter is optional in constructor', () {
final message = Message(
topic: 'phoenix',
event: ChannelEvents.heartbeat,
payload: {},
// ref is not provided, should be null
);
expect(message.ref, isNull);
final json = message.toJson();
expect(json.containsKey('ref'), isFalse);
});
});
}