ci(supabase_flutter): make WASM tests non-blocking#1306
Conversation
WASM tests have known infrastructure flakiness with 12+ minute loading timeouts in CI. This causes the entire job to fail due to timeout issues unrelated to code changes. Setting continue-on-error: true allows CI to continue while still running the tests for visibility. The WASM build step is still executed and any real test failures will be visible in the logs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughModified the GitHub Actions workflow to add error handling for the WASM web build and test step. The step now continues on failure with added comments documenting known infrastructure flakiness, while still reporting test results for visibility. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/supabase_flutter.yml (1)
90-97: Avoid masking WASM build failures.
continue-on-error: trueapplies to the entire step, so a brokenflutter build web --wasmwill also pass CI. If you only want flaky tests to be non-blocking, split the test and build into separate steps and keep the build blocking.✅ Suggested split to keep build blocking
- - name: Build and test web (WASM) - # WASM tests have known infrastructure flakiness (12min+ loading timeouts) - # Allow CI to continue while still running tests for visibility - continue-on-error: true - if: ${{ matrix.os == 'ubuntu-latest' && matrix.flutter-version == '3.x'}} - run: | - flutter test --platform chrome --wasm - cd example && flutter build web --wasm + - name: Test web (WASM) - non-blocking + # WASM tests have known infrastructure flakiness (12min+ loading timeouts) + # Allow CI to continue while still running tests for visibility + continue-on-error: true + if: ${{ matrix.os == 'ubuntu-latest' && matrix.flutter-version == '3.x'}} + run: flutter test --platform chrome --wasm + + - name: Build web (WASM) + if: ${{ matrix.os == 'ubuntu-latest' && matrix.flutter-version == '3.x'}} + run: cd example && flutter build web --wasm
Summary
continue-on-error: trueContext
The
flutter test --platform chrome --wasmstep has been timing out during the test loading phase (not execution), causing unrelated PRs to fail CI. This is an infrastructure issue with Flutter's WASM testing, not a code issue.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.