ci: drop standalone publish dry-run step#1378
Open
spydon wants to merge 1 commit into
Open
Conversation
dart pub publish --dry-run exits non-zero (code 65) when a package has warnings. Packages like supabase/supabase_flutter intentionally pin exact sibling versions (storage_client: 2.5.4, gotrue: ..., etc.), which pub reports as 'dependency should allow more than one version' warnings. That made the standalone dry-run step fail and skip the real publish, even though the actual publish (dart pub publish --force) publishes fine despite those warnings. The dedicated dry-run added no safety the real publish doesn't already provide, so remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dedicated "Publish dry run" step from
release-publish.yml.Why
storage_client published fine, but the
supabasepublish failed at the dry-run step (exit code 65):dart pub publish --dry-runexits non-zero when a package has warnings.supabase/supabase_flutterdeliberately pin exact sibling versions (storage_client: 2.5.4,gotrue: …, etc.) and override deps viapubspec_overrides.yaml, which pub flags as warnings. The standalone dry-run then failed and skipped the real publish.The real publish step runs
dart pub publish --force, which publishes despite those warnings (that's how supabase 2.10.6 shipped). So the dry-run gate added no safety the real publish doesn't already provide — it only produced false failures. Removing it.Follow-up to #1376 / #1377; storage_client 2.5.4 is already live.