Skip to content

Replace Math.random() with performance.now() in uuid() for pre-render… #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace Math.random() with performance.now() in uuid() for pre-render… #1844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions packages/core/auth-js/src/lib/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,27 @@ export function expiresAt(expiresIn: number) {
return timeNow + expiresIn
}

export function uuid() {
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function (c) {
const r = (Math.random() * 16) | 0,
v = c == 'x' ? r : (r & 0x3) | 0x8
return v.toString(16)
})
export function uuid(): string {
// Use performance.now() as primary entropy source
let counter = 0;
let state = 0;

return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, function (c) {
// Use performance timer if available
const perf = typeof performance !== 'undefined' ?
Math.floor(performance.now() * 1000000) : counter;

// Mix with counter using prime multiplication
const entropy = (perf * 16807) ^ (++counter * 2654435761);

// Simple hash mixing
state = (state * 1103515245 + 12345) ^ entropy;
const r = (state >>> (counter % 28)) & 0xF;

// Apply UUID v4 rules
const v = c == 'x' ? r : (r & 0x3) | 0x8;
return v.toString(16);
});
}

export const isBrowser = () => typeof window !== 'undefined' && typeof document !== 'undefined'
Expand Down