fix(realtime): terminate web worker on disconnect to prevent memory leak #1907
+37
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
This PR fixes a memory leak in RealtimeClient when using the
worker: trueoption. Web Workers were being created during connection but never properly cleaned up during disconnection, leading to memory accumulation over time.What changed?
Added
_terminateWorker()private methodworkerRefreference for garbage collectionUpdated
_teardownConnection()method_terminateWorker()during connection teardownAdded test coverage
workerRefis cleared after terminationWhy was this change needed?
When using RealtimeClient with
worker: true, each disconnect/reconnect cycle would create a new Web Worker without terminating the previous one. This caused:The fix ensures proper worker lifecycle management by terminating workers during connection teardown.
Closes #1902
📸 Screenshots/Examples
Before: Workers were created but never terminated
🔄 Breaking changes
📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting📝 Additional notes