fix(realtime): handle null values in postgres changes filter comparison #1918
+88
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
fixes the
mismatch between server and client bindings for postgres changeserror that occurs when subscribing to postgres_changes.problem
when the client subscribes without a filter:
the server returns
ilter: nullin the response, but the client hasilter: undefined. the strict equality checkull === undefinedreturns false, causing a false mismatch error.solution
added a helper method
isFilterValueEqualthat normalizes null to undefined before comparison. this handles the json serialization discrepancy between server and client.changes
RealtimeChannel.ts: use normalized comparison for schema, table, and filter fieldsRealtimeChannel.postgres.test.ts: added test cases for null and omitted filter scenariostesting
all 21 postgres tests pass including 2 new tests that specifically cover this bug.
closes #1917
cc @mandarini