Skip to content

fix(storage): correct signedUrl type to allow null in createSignedUrls#2254

Merged
mandarini merged 1 commit intomasterfrom
fix/storage-create-signed-urls-type
Apr 15, 2026
Merged

fix(storage): correct signedUrl type to allow null in createSignedUrls#2254
mandarini merged 1 commit intomasterfrom
fix/storage-create-signed-urls-type

Conversation

@mandarini
Copy link
Copy Markdown
Contributor

@mandarini mandarini commented Apr 15, 2026

The createSignedUrls return type declared signedUrl as string, but when a requested path does not exist the Storage server returns signedURL: null for that item and the client maps it to null in the ternary. This corrects the type to string | null so consumers can handle the partial-failure case without a type assertion. The mismatch was not caught by the compiler because the internal post() helper returns Promise<any>.

@mandarini mandarini requested review from a team as code owners April 15, 2026 14:07
@github-actions github-actions bot added the storage-js Related to the storage-js library. label Apr 15, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 15, 2026

Open in StackBlitz

@supabase/auth-js

npm i https://pkg.pr.new/@supabase/auth-js@2254

@supabase/functions-js

npm i https://pkg.pr.new/@supabase/functions-js@2254

@supabase/postgrest-js

npm i https://pkg.pr.new/@supabase/postgrest-js@2254

@supabase/realtime-js

npm i https://pkg.pr.new/@supabase/realtime-js@2254

@supabase/storage-js

npm i https://pkg.pr.new/@supabase/storage-js@2254

@supabase/supabase-js

npm i https://pkg.pr.new/@supabase/supabase-js@2254

commit: d30e01d

o-santi
o-santi previously approved these changes Apr 15, 2026
@mandarini mandarini merged commit c64f349 into master Apr 15, 2026
24 checks passed
@mandarini mandarini deleted the fix/storage-create-signed-urls-type branch April 15, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

storage-js Related to the storage-js library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants