tests: ignore 404 when double-checking bucket deletion #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR we introduced some changes to the tests. One of them was a cleanup function that double-checked all test buckets were deleted after the tests run, since the empty and delete methods of the bucket fixture don't run if the test that created the bucket fails.
Nevertheless, tests were still failing because of two reasons:
The solution to 1) is an easy try and except clause continuing the loop if the status code of the response in the StorageException is a 404.
The solution to 2) is using a list as a global variable to only track the buckets that have been created by the corresponding tests run, in order to delete these in the double_check.