Skip to content

Conversation

@Morioki
Copy link
Contributor

@Morioki Morioki commented Jun 3, 2022

Fixes #217

The code was modified to pass options.schema to the _init_postgrest_client function through a new schema parameter to in turn pass the schema information to the SyncPostgrestClient constructor.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.55%.

Quality metrics Before After Change
Complexity 0.94 ⭐ 0.94 ⭐ 0.00
Method Length 25.80 ⭐ 26.40 ⭐ 0.60 👎
Working memory 5.94 ⭐ 6.06 ⭐ 0.12 👎
Quality 83.49% 82.94% -0.55% 👎
Other metrics Before After Change
Lines 153 152 -1
Changed files Quality Before Quality After Quality Change
supabase/client.py 83.49% ⭐ 82.94% ⭐ -0.55% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@anand2312
Copy link
Contributor

@Morioki can you format the file with black as well? CI pre-commit is complaining
I'll merge once CI passes

@Morioki
Copy link
Contributor Author

Morioki commented Jun 6, 2022

@anand2312, apologies for not running the formatter before the initial commit. Formatting has now been applied to the client.py using black.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #218 (c71261f) into develop (53a6c95) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files            8        8           
  Lines          125      125           
========================================
  Hits           100      100           
  Misses          25       25           
Impacted Files Coverage Δ
supabase/client.py 90.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a6c95...c71261f. Read the comment docs.

@anand2312
Copy link
Contributor

Thanks for the PR 🚀

@anand2312 anand2312 merged commit 6f2b516 into supabase:develop Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client does not use alternative schema when provided

2 participants