Skip to content

chore(studio): vector buckets polish A#39759

Merged
ivasilov merged 7 commits intoivan/depr-91-add-skeleton-of-vector-bucket-contents-to-storagefrom
dnywh/chore/vector-bucket-polish
Oct 22, 2025
Merged

chore(studio): vector buckets polish A#39759
ivasilov merged 7 commits intoivan/depr-91-add-skeleton-of-vector-bucket-contents-to-storagefrom
dnywh/chore/vector-bucket-polish

Conversation

@dnywh
Copy link
Contributor

@dnywh dnywh commented Oct 22, 2025

What kind of change does this PR introduce?

Chore: more UI improvements to the vector buckets and their details

What is the current behavior?

  • Vector buckets don’t have a proper empty state when there are no tables (AKA indexes)
  • The table creation flow had some design inconsistencies with other sheets

What is the new behavior?

  • UI and copywriting improvements to the above areas
  • Minor copywriting improvements more generally
  • Renamed references of “index” to “table” since that’s our nomenclature for vector indexes tables

Additional context

Based branch: #39597.

Still to come:

  • Delete bucket modal

To test

Use MOCK_VECTOR_INDEXES for allIndexes in VectorBucketDetails (here) if you need mock table data.

@dnywh dnywh requested a review from a team as a code owner October 22, 2025 07:35
@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Oct 22, 2025 7:39am
studio-staging Ready Ready Preview Comment Oct 22, 2025 7:39am
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Oct 22, 2025 7:39am
cms Skipped Skipped Oct 22, 2025 7:39am
design-system Skipped Skipped Oct 22, 2025 7:39am
docs Skipped Skipped Oct 22, 2025 7:39am
ui-library Skipped Skipped Oct 22, 2025 7:39am
zone-www-dot-com Skipped Skipped Oct 22, 2025 7:39am

@supabase
Copy link

supabase bot commented Oct 22, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@dnywh dnywh changed the title Dnywh/chore/vector bucket polish chore(studio): vector buckets polish A Oct 22, 2025
<FormControl_Shadcn_>
<div className="flex flex-col gap-y-2">
<p className="text-smn">Function to trigger</p>
<p className="text-sm">Function to trigger</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo I noticed elsewhere, unrelated to this effort. Feel free to remove if it muddies the later merge.


export const CreateVectorIndexSheet = () => {
interface CreateVectorTableSheetProps {
bucketName: string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can reference the bucketName in the Target schema field. Honestly I might do away with this field entirely, later. Not sure how helpful it is for people to know this.

id="targetSchema"
{...field}
placeholder="tdai_data"
value={bucketName}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above.

Comment on lines +39 to +40
dimension: 1536,
distanceMetric: 'cosine',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduced these. Sorry. Figured they are helpful to show in the table because they are required options upon table creation.

@ivasilov ivasilov merged commit 2e6fbdd into ivan/depr-91-add-skeleton-of-vector-bucket-contents-to-storage Oct 22, 2025
15 of 17 checks passed
@ivasilov ivasilov deleted the dnywh/chore/vector-bucket-polish branch October 22, 2025 08:56
ivasilov pushed a commit that referenced this pull request Oct 31, 2025
* empty state

* better checks

* bucket name in sheet

* fix typo

* sheet improvements

* rename vector index to vector table

* cleanup
ivasilov added a commit that referenced this pull request Nov 4, 2025
* Initial work on vector buckets.

* Add more queries and UI.

* chore(studio): vector buckets contents (#39705)

* language

* match analytics buckets

* shared empty state

* proper loading state

* create dialog cleanup

* simplify copywriting

* proper details

* filtering

* use real data

* chore(studio): vector buckets polish A (#39759)

* empty state

* better checks

* bucket name in sheet

* fix typo

* sheet improvements

* rename vector index to vector table

* cleanup

* More work on the vector indexes.

* Add delete for bucket and indexes. Create index should now work.

* chore(studio): vector buckets polish B (#39794)

* loading

* delete modal

* fix modal behaviour

* Add modal for deleting vector buckets.

* Bring back the shimmering loader.

* chore(studio): vector buckets polish C (#39887)

* fix bucketname on deletion dialog

* empty states

* remove extraneous padding

* proper loading and not-found cases

* Minor fixes.

* Minor updates to the vector components.

* Add more instructions to the cursor rules.

* Some refactors and shifting files around

* Refactor analytics buckets detial to improve time to fcp

* Fix

* Refactors + simplify

* Last few nits, just leaving comments

* If the bucket is not empty, delete all indexes first.

---------

Co-authored-by: Danny White <3104761+dnywh@users.noreply.github.com>
Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Rodriguespn pushed a commit that referenced this pull request Nov 25, 2025
* Initial work on vector buckets.

* Add more queries and UI.

* chore(studio): vector buckets contents (#39705)

* language

* match analytics buckets

* shared empty state

* proper loading state

* create dialog cleanup

* simplify copywriting

* proper details

* filtering

* use real data

* chore(studio): vector buckets polish A (#39759)

* empty state

* better checks

* bucket name in sheet

* fix typo

* sheet improvements

* rename vector index to vector table

* cleanup

* More work on the vector indexes.

* Add delete for bucket and indexes. Create index should now work.

* chore(studio): vector buckets polish B (#39794)

* loading

* delete modal

* fix modal behaviour

* Add modal for deleting vector buckets.

* Bring back the shimmering loader.

* chore(studio): vector buckets polish C (#39887)

* fix bucketname on deletion dialog

* empty states

* remove extraneous padding

* proper loading and not-found cases

* Minor fixes.

* Minor updates to the vector components.

* Add more instructions to the cursor rules.

* Some refactors and shifting files around

* Refactor analytics buckets detial to improve time to fcp

* Fix

* Refactors + simplify

* Last few nits, just leaving comments

* If the bucket is not empty, delete all indexes first.

---------

Co-authored-by: Danny White <3104761+dnywh@users.noreply.github.com>
Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants