Skip to content

Conversation

@dnywh
Copy link
Contributor

@dnywh dnywh commented Nov 13, 2025

What kind of change does this PR introduce?

  • Feature flag tweaks
  • Resolves DEPR-134

What is the current behavior?

  • The securityNotifications flag’s related feature preview is opt-in
    • Meaning all users must explicitly opt-in to see the feature

What is the new behavior?

  • The securityNotifications flag’s related feature preview is opt-out
    • Meaning all users have this feature preview enabled, and must explicitly opt-out to go back to the previous UI

Note

We need to set the corresponding ConfigCat flag to 20% (or similar) to avoid rolling this out to everyone all at once.

Additional context

I decided not to update the notice Admonition (with a link back to this feature preview in case folks want to later opt-out) because:

  • I don’t think it’s a controversial enough change
  • The Admonition is already quite lengthy

@dnywh dnywh requested a review from a team as a code owner November 13, 2025 09:01
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
studio-self-hosted Ready Ready Preview Comment Nov 13, 2025 10:01am
studio-staging Ready Ready Preview Comment Nov 13, 2025 10:01am
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
studio Ignored Ignored Nov 13, 2025 10:01am
cms Skipped Skipped Nov 13, 2025 10:01am
design-system Skipped Skipped Nov 13, 2025 10:01am
docs Skipped Skipped Nov 13, 2025 10:01am
ui-library Skipped Skipped Nov 13, 2025 10:01am
zone-www-dot-com Skipped Skipped Nov 13, 2025 10:01am

@supabase
Copy link

supabase bot commented Nov 13, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coveralls
Copy link

coveralls commented Nov 13, 2025

Coverage Status

coverage: 68.718%. remained the same
when pulling 243e892 on dnywh/chore/security-notifs-incremental-rollout
into 482aeb7 on master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Studio E2E Results

  • Total: 1
  • Passed: 1
  • Failed: 0
  • Skipped: 0
  • Timed out: 0
  • Interrupted: 0
  • Flaky: 0
  • Duration: 3.0s

Artifacts: https://github.com/supabase/supabase/actions/runs/19327516266

Last updated: Thursday 13, November, 2025 10:12:45 (UTC)

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified changes on staging! minimally that feature preview is still available

@joshenlim joshenlim merged commit cb72c30 into master Nov 13, 2025
20 of 21 checks passed
@joshenlim joshenlim deleted the dnywh/chore/security-notifs-incremental-rollout branch November 13, 2025 10:29
@joshenlim
Copy link
Member

JFYI the E2E tests were failing on this branch (specifically database.spec) somehow despite multiple re-runs, but i've checked locally
all seems alright
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants