Skip to content

chore(studio): default opt-in security notifications #40423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
+4 −9
Merged

chore(studio): default opt-in security notifications #40423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0587e2
default opt-in
dnywh Nov 13, 2025
243e892
Tiny clean up
joshenlim Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions apps/studio/components/interfaces/App/FeaturePreview/FeaturePreviewContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@ export const useFeaturePreviewContext = () => useContext(FeaturePreviewContext)

export const FeaturePreviewContextProvider = ({ children }: PropsWithChildren<{}>) => {
const { hasLoaded } = useContext(FeatureFlagContext)
const securityNotificationsFlag = useFlag('securityNotifications')

// [Joshen] Similar logic to feature flagging previews, we can use flags to default opt in previews
const isDefaultOptIn = (feature: (typeof FEATURE_PREVIEWS)[number]) => {
switch (feature.key) {
case LOCAL_STORAGE_KEYS.UI_PREVIEW_SECURITY_NOTIFICATIONS:
return securityNotificationsFlag
default:
return false
}
Expand Down Expand Up @@ -116,7 +119,6 @@ export const useFeaturePreviewModal = () => {
const gitlessBranchingEnabled = useFlag('gitlessBranching')
const advisorRulesEnabled = useFlag('advisorRules')
const isUnifiedLogsPreviewAvailable = useFlag('unifiedLogs')
const isSecurityNotificationsAvailable = useFlag('securityNotifications')

const selectedFeatureKeyFromQuery = featurePreviewModal?.trim() ?? null
const showFeaturePreviewModal = selectedFeatureKeyFromQuery !== null
Expand All @@ -131,18 +133,11 @@ export const useFeaturePreviewModal = () => {
return advisorRulesEnabled
case 'supabase-ui-preview-unified-logs':
return isUnifiedLogsPreviewAvailable
case 'security-notifications':
return isSecurityNotificationsAvailable
default:
return true
}
},
[
gitlessBranchingEnabled,
advisorRulesEnabled,
isUnifiedLogsPreviewAvailable,
isSecurityNotificationsAvailable,
]
[gitlessBranchingEnabled, advisorRulesEnabled, isUnifiedLogsPreviewAvailable]
)

const selectedFeatureKey = (
Expand Down
Loading