Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
Contributor
🎭 Playwright Test ResultsDetails
|
charislam
reviewed
Nov 20, 2025
Contributor
charislam
left a comment
There was a problem hiding this comment.
I can't seem to get the default main.py script working. Tried several times with two different buckets and I keep getting a 403 on /storage/v1/iceberg/v1/config
...interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/CreateTableInstructions/index.tsx
Outdated
Show resolved
Hide resolved
...nts/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/index.tsx
Outdated
Show resolved
Hide resolved
...nts/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/index.tsx
Outdated
Show resolved
Hide resolved
...es/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/TableRowComponent.tsx
Outdated
Show resolved
Hide resolved
...es/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/TableRowComponent.tsx
Outdated
Show resolved
Hide resolved
...es/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/TableRowComponent.tsx
Outdated
Show resolved
Hide resolved
...es/Storage/AnalyticsBuckets/AnalyticsBucketDetails/NamespaceWithTables/TableRowComponent.tsx
Outdated
Show resolved
Hide resolved
...nts/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/UpdateForeignSchemaDialog.tsx
Outdated
Show resolved
Hide resolved
...nts/interfaces/Storage/AnalyticsBuckets/AnalyticsBucketDetails/UpdateForeignSchemaDialog.tsx
Outdated
Show resolved
Hide resolved
…lyticsBucketDetails/NamespaceWithTables/TableRowComponent.tsx Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
alaister
approved these changes
Nov 21, 2025
Member
alaister
left a comment
There was a problem hiding this comment.
LGTM!
- Tested as instructed on preview
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We're scoping down the technicalities of Analytics Buckets by de-coupling it from ETL replication (so Analytics Bucket will just be about the buckets themselves), which helps us simplify a lot of the complexities around the UI + makes the UI behaviour a lot more deterministic and fault tolerant.
Main user flows covered will be:
The decision of whether to fully de-couple ETL from Analytics Bucket is still in the air, so decided to leave all of the relevant code as is for now, in case we'll revisit them again down the road. On that note though, the code might be a little messy but I hope to clean things up bit by bit in subsequent PRs.
Changes involved
Our primary CTA of creating tables in a bucket will be to do so through an external Iceberg client - so the empty state is a set of instructions for Pyiceberg which should work out of the box.

The sample snippet here will create a namespace called

defaultand a tableeventswithin that namespace. (There's no automatic polling so you'll need to refresh the browser here)You can opt to view the data in the Iceberg table via Postgres by following the "Query from Postgres" which then explains + prompts you to do so via Foreign Data Wrappers. At this step you just need to specify which schema you'd want to have the foreign tables in.

This then creates the foreign tables and shows you how you can view the data of your iceberg table from

From here that's pretty much it in terms of functionality. You can then choose to delete individual iceberg tables (which also cleans up any associated foreign tables), or delete the whole namespace (which will also clean up any associated foreign tables for iceberg tables in the namespace)
Past the empty state, the "Create table" CTA then shifts up to the header section (as per Vector Buckets), where clicking just opens the set of instructions within a Dialog. (The relevancy of these instructions at this state is up for future debate but good for now)
Known issues
To test