Skip to content

fix: update description for working directory#42434

Merged
sweatybridge merged 1 commit intomasterfrom
fix-desc
Feb 4, 2026
Merged

fix: update description for working directory#42434
sweatybridge merged 1 commit intomasterfrom
fix-desc

Conversation

@sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Feb 4, 2026

What kind of change does this PR introduce?

Bug fix supabase/cli#4793

What is the new behavior?

Updates config description to be less confusing.

Additional context

Add any other context or screenshots.

Summary by CodeRabbit

  • Style
    • Updated field labels in GitHub integration settings for clarity—renamed "Supabase directory" to "Working directory" with revised description text.

@sweatybridge sweatybridge requested a review from a team as a code owner February 4, 2026 03:34
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
studio-self-hosted Ready Ready Preview, Comment Feb 4, 2026 3:37am
studio-staging Ready Ready Preview, Comment Feb 4, 2026 3:37am
6 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Feb 4, 2026 3:37am
studio Ignored Ignored Feb 4, 2026 3:37am
design-system Skipped Skipped Feb 4, 2026 3:37am
docs Skipped Skipped Feb 4, 2026 3:37am
ui-library Skipped Skipped Feb 4, 2026 3:37am
zone-www-dot-com Skipped Skipped Feb 4, 2026 3:37am

Request Review

@supabase
Copy link

supabase bot commented Feb 4, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Walkthrough

Updated UI labels and descriptions in the GitHub integration settings form to clarify that the field expects the working directory path (containing the supabase folder) rather than the supabase directory itself.

Changes

Cohort / File(s) Summary
GitHub Integration Form UI
apps/studio/components/interfaces/Settings/Integrations/GithubIntegration/GitHubIntegrationConnectionForm.tsx
Updated field label from "Supabase directory" to "Working directory" and description from "Relative path to your supabase folder" to "Path to working directory with your supabase folder" for improved clarity.
🚥 Pre-merge checks | ✅ 2 | ❌ 3
❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description identifies the PR as a bug fix with issue reference but is missing the required CONTRIBUTING.md acknowledgment section and is notably sparse on details about the actual changes. Add confirmation that CONTRIBUTING.md was read and provide more detailed explanation of what descriptions were changed and why, beyond 'less confusing.'
Linked Issues check ⚠️ Warning The PR updates UI descriptions for the working directory field but does not address the core bug in issue #4793: the branching executor incorrectly doubles the seed.sql path resolution logic. The linked issue requires fixing the path doubling bug in the branching executor logic. UI description changes alone do not resolve the root cause of incorrect path resolution.
Out of Scope Changes check ❓ Inconclusive The change updates UI field labels and descriptions in the GitHub integration form, which is in-scope for the bug fix objective but appears to be a partial or workaround fix rather than addressing the core path resolution issue. Clarify whether updating UI descriptions is the complete fix for issue #4793 or if additional backend logic changes are required to resolve the path doubling problem.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: update description for working directory' is specific and directly relates to the code change, which updates field labels and descriptions in the GitHub integration form.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-desc

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sweatybridge sweatybridge enabled auto-merge (squash) February 4, 2026 03:45
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

🎭 Playwright Test Results

passed  84 passed
flaky  2 flaky
skipped  4 skipped

Details

stats  90 tests across 14 suites
duration  10 minutes, 56 seconds
commit  eb8e250

Flaky tests

Features › index-advisor.spec.ts › Index Advisor › Enable Index Advisor › should enable Index Advisor via Database > Extensions page
Features › index-advisor.spec.ts › Index Advisor › Index Advisor Functionality › should create test table without indexes

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@sweatybridge sweatybridge merged commit 3bf3750 into master Feb 4, 2026
25 of 26 checks passed
@sweatybridge sweatybridge deleted the fix-desc branch February 4, 2026 03:51
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Braintrust eval report

Assistant (master-1770177196)

Score Average Improvements Regressions
Completeness 100% (+0pp) - -
Conciseness 0% (+0pp) - -
Docs Faithfulness 50% (-8pp) 1 🟢 -
Goal Completion 100% (+4pp) 1 🟢 -
Tool Usage 100% (+0pp) - -
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+0pp) - -
Correctness 100% (+0pp) - -
URL Validity 100% (+0pp) - -
Time_to_first_token 0.21tok (-0.01tok) 5 🟢 7 🔴
Llm_calls 8.42 (-0.08) 2 🟢 3 🔴
Tool_calls 3.08 (+0.08) 2 🟢 3 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 94780.5tok (-10904.5tok) 5 🟢 7 🔴
Prompt_cached_tokens 36800tok (-12522.67tok) 3 🟢 4 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 4963.08tok (-260.75tok) 10 🟢 2 🔴
Completion_reasoning_tokens 3413.33tok (-277.33tok) 8 🟢 3 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 99743.58tok (-11165.25tok) 8 🟢 4 🔴
Estimated_cost 0.03$ (0$) 8 🟢 4 🔴
Duration 37.37s (-4.02s) 9 🟢 3 🔴
Llm_duration 70.97s (-10.87s) 10 🟢 2 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branching executor doubles seed.sql path (looks for supabase/supabase/seed.sql)

2 participants