Skip to content

Remove default freeze on PK column in table editor#42636

Merged
joshenlim merged 1 commit intomasterfrom
joshen/fe-2504-stop-freezing-primary-key-column-by-default-in-table-editor
Feb 10, 2026
Merged

Remove default freeze on PK column in table editor#42636
joshenlim merged 1 commit intomasterfrom
joshen/fe-2504-stop-freezing-primary-key-column-by-default-in-table-editor

Conversation

@joshenlim
Copy link
Copy Markdown
Member

@joshenlim joshenlim commented Feb 10, 2026

Context

Just removes the default column freeze behaviour on primary key columns in the table editor. Behaviour should still persist if freezing manually.

Summary by CodeRabbit

  • Updates
    • Grid columns are no longer frozen based on primary key designation.

@joshenlim joshenlim requested a review from a team as a code owner February 10, 2026 03:15
@supabase
Copy link
Copy Markdown

supabase Bot commented Feb 10, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
learn Ready Ready Preview, Comment Feb 10, 2026 3:18am
studio-self-hosted Ready Ready Preview, Comment Feb 10, 2026 3:18am
studio-staging Ready Ready Preview, Comment Feb 10, 2026 3:18am
6 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Feb 10, 2026 3:18am
studio Ignored Ignored Feb 10, 2026 3:18am
design-system Skipped Skipped Feb 10, 2026 3:18am
docs Skipped Skipped Open in v0 Feb 10, 2026 3:18am
ui-library Skipped Skipped Feb 10, 2026 3:18am
zone-www-dot-com Skipped Skipped Open in v0 Feb 10, 2026 3:18am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

Walkthrough

This PR removes the default frozen state for primary key columns in the table editor grid, allowing them to scroll horizontally alongside other columns. It includes reordered imports and adds an import for pending-add-row handling.

Changes

Cohort / File(s) Summary
Grid Column Frozen State
apps/studio/components/grid/utils/gridColumns.tsx
Removed primary key influence on column frozen state by changing frozen: x.isPrimaryKey || false to frozen: false. Added import of isPendingAddRow for pending-add-row handling in existing logic.
Import Reordering
apps/studio/components/grid/utils/queueOperationUtils.ts
Reordered import declarations without functional changes. Entity and isPendingAddRow imports repositioned for consistency.
🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is minimal and lacks the structured format specified in the template, missing required sections like kind of change, current behavior with issue links, and new behavior details. Expand the description to follow the template: specify 'Bug fix' as the change type, link issue FE-2504, detail current frozen behavior, and describe the new unfrozen behavior.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing the default freeze behavior on primary key columns in the table editor.
Linked Issues check ✅ Passed The code changes directly address FE-2504 by removing the isPrimaryKey condition from the frozen column logic, eliminating automatic freezing while preserving manual freeze capability.
Out of Scope Changes check ✅ Passed All changes are scoped to the objective: the primary modification removes the isPrimaryKey freeze condition, and import reordering is a minor supporting change without functional impact.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch joshen/fe-2504-stop-freezing-primary-key-column-by-default-in-table-editor

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 65.978%. remained the same
when pulling c57bae9 on joshen/fe-2504-stop-freezing-primary-key-column-by-default-in-table-editor
into 5b8ca1b on master.

@github-actions
Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

passed  102 passed
flaky  4 flaky
skipped  4 skipped

Details

stats  110 tests across 17 suites
duration  12 minutes, 55 seconds
commit  c57bae9

Flaky tests

Features › cron-jobs.spec.ts › High Query Cost Banner › shows banner and still displays cron jobs when query cost exceeds threshold
Features › rls-policies.spec.ts › RLS Policies › Policies Page › should display policies page correctly
Features › rls-policies.spec.ts › RLS Policies › Create RLS Policy › should create an UPDATE policy with custom condition
Features › table-editor.spec.ts › table editor › view table definition works as expected

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@joshenlim joshenlim merged commit 0962bcc into master Feb 10, 2026
26 checks passed
@joshenlim joshenlim deleted the joshen/fe-2504-stop-freezing-primary-key-column-by-default-in-table-editor branch February 10, 2026 03:49
@github-actions
Copy link
Copy Markdown
Contributor

Braintrust eval report

Evals in progress... ⌛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants