feat(etl): Add new setting for controlling table copy#42853
feat(etl): Add new setting for controlling table copy#42853iambriccardo merged 6 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request refactors the replication pipeline configuration by renaming and repositioning form fields to better reflect their functionality. The field Comment |
🎭 Playwright Test Results
Details
Flaky testsFeatures › cron-jobs.spec.ts › High Query Cost Banner › shows banner and still displays cron jobs when query cost exceeds threshold Skipped testsFeatures › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
> [!CAUTION]
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)packages/api-types/types/api.d.ts (1)
1-4:⚠️ Potential issue | 🟠 MajorDo not edit generated api.d.ts directly.
This file is auto-generated; changes must be made in the OpenAPI spec (e.g., apps/docs/spec/api_v1_openapi.json) and then regenerated, otherwise types will drift from the source of truth.
Based on learnings: “Generated type definitions under packages/api-types/types/**/*.d.ts are auto-generated by openapi-typescript and should not be edited directly. Do not modify these files. If a change is needed, update the OpenAPI spec and regenerate the types.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/api-types/types/api.d.ts` around lines 1 - 4, The file packages/api-types/types/api.d.ts is auto-generated and must not be edited directly; instead update the OpenAPI spec (e.g., apps/docs/spec/api_v1_openapi.json) with the desired changes and then regenerate the TypeScript types using the openapi-typescript generation step (the project’s generator/script that produces packages/api-types/types/**/*.d.ts), ensuring the generated types reflect the spec and avoiding manual edits to Api.d.ts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/api-types/types/api.d.ts`:
- Around line 1-4: The file packages/api-types/types/api.d.ts is auto-generated
and must not be edited directly; instead update the OpenAPI spec (e.g.,
apps/docs/spec/api_v1_openapi.json) with the desired changes and then regenerate
the TypeScript types using the openapi-typescript generation step (the project’s
generator/script that produces packages/api-types/types/**/*.d.ts), ensuring the
generated types reflect the spec and avoiding manual edits to Api.d.ts.
ℹ️ Review info
Configuration used: Central YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
apps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/AdvancedSettings.tsxapps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/DestinationForm.schema.tsapps/studio/components/interfaces/Database/Replication/DestinationPanel/DestinationForm/index.tsxapps/studio/data/replication/create-destination-pipeline-mutation.tsapps/studio/data/replication/update-destination-pipeline-mutation.tsapps/studio/data/replication/validate-pipeline-mutation.tspackages/api-types/types/api.d.tspackages/api-types/types/platform.d.ts
Braintrust eval report
|
2 participants
This PR changes advanced settings for ETL.