fix: add minio password generator and amend docs#42862
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
7 Skipped Deployments
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughAdds three new environment variables for S3/MinIO to the self-hosting Docker docs and updates the Docker key-generation script to generate and persist MINIO_ROOT_PASSWORD (16-byte hex), emitting it in the script status and updating the .env via sed. Changes
Sequence Diagram(s)(omitted — changes are limited to docs and a single script; no new multi-component control flow introduced) Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apps/docs/content/guides/self-hosting/docker.mdx`:
- Line 187: Add the same spell-check lint-disable/enable comments used elsewhere
in this file around the MinIO environment variable line: insert the file's
existing lint-disable comment immediately before the line containing
`MINIO_ROOT_PASSWORD` and place the corresponding lint-enable comment right
after that line (matching the pattern used around other MinIO mentions in this
file) so the pipeline no longer flags "MinIO".
- Line 186: Typo in the docs: replace the misspelled command `opensssl rand -hex
32` with the correct `openssl rand -hex 32` in the description for
S3_PROTOCOL_ACCESS_KEY_SECRET so users can successfully generate the secret;
update the text near the S3_PROTOCOL_ACCESS_KEY_SECRET environment variable
entry and ensure the inline code block uses the corrected `openssl` command.
Braintrust eval report
|
I have read the CONTRIBUTING.md file.
YES/NO
What kind of change does this PR introduce?
A follow up to PR #37185:
utils/generate-keys.shSummary by CodeRabbit
Documentation
Chores