fix: cannot resize table editor columns on safari#43450
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Central YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request applies a patch to react-data-grid's compiled bundles (lib/bundle.cjs and lib/bundle.js) modifying HeaderCell's internal event handling: the onLostPointerCapture handler now takes no parameters and its conditional call to onPointerMove(event) when hasDoubleClicked was false has been removed. pnpm-workspace.yaml was updated with dependency overrides (tar and openapi-related entries), added lodash-es and next to the catalog, and registered the react-data-grid patch in patchedDependencies. Multiple GitHub Actions workflows were modified to include the top-level patches directory in their sparse-checkout lists. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test ResultsDetails
Flaky testsFeatures › database.spec.ts › Database › Schema Visualizer › actions works as expected Skipped testsFeatures › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected |
Braintrust eval report
|
Problem
On Safari, it's impossible to resize a column.
Solution
This is actually a bug in
react-data-gridthat has been fixed in more recent versions but we can't use them.Patch the package
How to test