Skip to content

fix: cannot resize table editor columns on safari#43450

Merged
djhi merged 4 commits intomasterfrom
fe-2663-cannot-resize-columns-in-table-editor-in-safari
Mar 6, 2026
Merged

fix: cannot resize table editor columns on safari#43450
djhi merged 4 commits intomasterfrom
fe-2663-cannot-resize-columns-in-table-editor-in-safari

Conversation

@djhi
Copy link
Contributor

@djhi djhi commented Mar 5, 2026

Problem

On Safari, it's impossible to resize a column.

Solution

This is actually a bug in react-data-grid that has been fixed in more recent versions but we can't use them.
Patch the package

How to test

  • Open the any table in the Table editor
  • Resize a column

@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Ready Ready Preview, Comment Mar 5, 2026 5:41pm
docs Ready Ready Preview, Comment, Open in v0 Mar 5, 2026 5:41pm
learn Ready Ready Preview, Comment Mar 5, 2026 5:41pm
studio-self-hosted Ready Ready Preview, Comment Mar 5, 2026 5:41pm
studio-staging Ready Ready Preview, Comment Mar 5, 2026 5:41pm
ui-library Ready Ready Preview, Comment Mar 5, 2026 5:41pm
zone-www-dot-com Ready Ready Preview, Comment, Open in v0 Mar 5, 2026 5:41pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
cms Ignored Ignored Mar 5, 2026 5:41pm
studio Ignored Ignored Mar 5, 2026 5:41pm

Request Review

@supabase
Copy link

supabase bot commented Mar 5, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Central YAML (base), Repository UI (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e283a9ef-1340-4e70-b6ca-7dbf6b600e53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request applies a patch to react-data-grid's compiled bundles (lib/bundle.cjs and lib/bundle.js) modifying HeaderCell's internal event handling: the onLostPointerCapture handler now takes no parameters and its conditional call to onPointerMove(event) when hasDoubleClicked was false has been removed. pnpm-workspace.yaml was updated with dependency overrides (tar and openapi-related entries), added lodash-es and next to the catalog, and registered the react-data-grid patch in patchedDependencies. Multiple GitHub Actions workflows were modified to include the top-level patches directory in their sparse-checkout lists.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🎭 Playwright Test Results

passed  149 passed
flaky  2 flaky
skipped  4 skipped

Details

stats  155 tests across 20 suites
duration  10 minutes, 16 seconds
commit  c1c70e7

Flaky tests

Features › database.spec.ts › Database › Schema Visualizer › actions works as expected
Features › realtime-inspector.spec.ts › Realtime Inspector › Broadcast Messages › broadcast modal validates JSON payload

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview on Safari

@djhi djhi merged commit 7700401 into master Mar 6, 2026
32 checks passed
@djhi djhi deleted the fe-2663-cannot-resize-columns-in-table-editor-in-safari branch March 6, 2026 07:01
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Braintrust eval report

Assistant (master-1772780941)

Score Average Improvements Regressions
Completeness 97.2% (-3pp) - 1 🔴
Conciseness 0% (+0pp) - -
Goal Completion 93.1% (-3pp) 1 🟢 2 🔴
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+0pp) - -
Tool Usage 100% (+0pp) - -
Correctness 100% (+8pp) 1 🟢 -
Docs Faithfulness 63.9% (+8pp) 1 🟢 -
URL Validity 100% (+10pp) - -
Time_to_first_token 0.22tok (-0.05tok) 9 🟢 3 🔴
Llm_calls 8.28 (-0.06) 2 🟢 3 🔴
Tool_calls 3.03 (-0.08) 3 🟢 4 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 44373.03tok (-3883.06tok) 10 🟢 2 🔴
Prompt_cached_tokens 22136.89tok (-5432.89tok) 3 🟢 9 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 2712.64tok (-56.39tok) 6 🟢 6 🔴
Completion_reasoning_tokens 1925.33tok (+1.78tok) 5 🟢 7 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 47085.67tok (-3939.44tok) 10 🟢 2 🔴
Estimated_cost 0.01$ (+0$) 7 🟢 5 🔴
Duration 41.3s (-3.21s) 7 🟢 5 🔴
Llm_duration 80.83s (-6.72s) 7 🟢 5 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants