Skip to content

allow empty string in saml metadata url#44392

Merged
Ellba merged 1 commit intomasterfrom
fix-allow-optional-saml-metadata-url
Mar 31, 2026
Merged

allow empty string in saml metadata url#44392
Ellba merged 1 commit intomasterfrom
fix-allow-optional-saml-metadata-url

Conversation

@Ellba
Copy link
Copy Markdown
Contributor

@Ellba Ellba commented Mar 31, 2026

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

SAML metadata URL cannot be saved with an empty string; it works through the management API

image

What is the new behavior?

Allow saving SAML 2.0 config with an empty SAML metadata URL

@Ellba Ellba requested a review from a team as a code owner March 31, 2026 14:52
@supabase
Copy link
Copy Markdown

supabase bot commented Mar 31, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
studio-self-hosted Ready Ready Preview, Comment Mar 31, 2026 2:56pm
studio-staging Ready Ready Preview, Comment Mar 31, 2026 2:56pm
6 Skipped Deployments
Project Deployment Actions Updated (UTC)
studio Ignored Ignored Mar 31, 2026 2:56pm
design-system Skipped Skipped Mar 31, 2026 2:56pm
docs Skipped Skipped Open in v0 Mar 31, 2026 2:56pm
learn Skipped Skipped Mar 31, 2026 2:56pm
ui-library Skipped Skipped Mar 31, 2026 2:56pm
zone-www-dot-com Skipped Skipped Open in v0 Mar 31, 2026 2:56pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

🎭 Playwright Test Results

passed  175 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  180 tests across 20 suites
duration  3 minutes, 56 seconds
commit  b43d8dc

Flaky tests

Features › queue-table-operations.spec.ts › Queue Table Operations › pending changes persist when switching between tables

Skipped tests

Features › sql-editor.spec.ts › SQL Editor › snippet favourite works as expected
Features › sql-editor.spec.ts › SQL Editor › share with team works as expected
Features › sql-editor.spec.ts › SQL Editor › folders works as expected
Features › sql-editor.spec.ts › SQL Editor › other SQL snippets actions work as expected

@Ellba Ellba merged commit fabf65f into master Mar 31, 2026
31 checks passed
@Ellba Ellba deleted the fix-allow-optional-saml-metadata-url branch March 31, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants