Skip to content

fix nimbus search#45331

Merged
charislam merged 1 commit into
masterfrom
charis/fix-nimbus-search
Apr 28, 2026
Merged

fix nimbus search#45331
charislam merged 1 commit into
masterfrom
charis/fix-nimbus-search

Conversation

@charislam
Copy link
Copy Markdown
Contributor

@charislam charislam commented Apr 28, 2026

Nimbus search is broken because it expects the page section to be joined with the page table, but this table is called page_nimbus in Nimbus mode.

Resolves AI-682

Summary by CodeRabbit

  • Bug Fixes
    • Fixed source reference attribution to use the correct path when using the alternate search index option.

Nimbus search is broken because it expects the page section to be joined
with the page table, but this table is called page_nimbus in Nimbus
mode.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment, Open in v0 Apr 28, 2026 4:01pm
studio-self-hosted Ready Ready Preview, Comment Apr 28, 2026 4:01pm
studio-staging Ready Ready Preview, Comment Apr 28, 2026 4:01pm
zone-www-dot-com Ready Ready Preview, Comment, Open in v0 Apr 28, 2026 4:01pm
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
studio Ignored Ignored Apr 28, 2026 4:01pm
design-system Skipped Skipped Apr 28, 2026 4:01pm
learn Skipped Skipped Apr 28, 2026 4:01pm
ui-library Skipped Skipped Apr 28, 2026 4:01pm

Request Review

@supabase
Copy link
Copy Markdown

supabase Bot commented Apr 28, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e97aaa59-3f30-4c0b-9143-305a1aedf95b

📥 Commits

Reviewing files that changed from the base of the PR and between e7c33bf and 773682f.

📒 Files selected for processing (1)
  • packages/ai-commands/src/docs.ts

📝 Walkthrough

Walkthrough

The clippy function in packages/ai-commands/src/docs.ts now conditionally derives the source pagePath based on the options.useAltSearchIndex flag. When the alternate Nimbus search index is enabled, it reads page_nimbus.path; otherwise, it defaults to page.path.

Changes

Cohort / File(s) Summary
Conditional pagePath Resolution
packages/ai-commands/src/docs.ts
Modified clippy function to select pagePath dynamically: uses page_nimbus.path when options.useAltSearchIndex is true, otherwise uses page.path for source reference attribution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path through the index, we now choose with care,
When Nimbus beckons, we take the alternate air,
One condition, one switch, a logic so clean,
The finest of tweaks a code-hopper's seen!
~Signed, the Code Rabbit 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks required template sections including CONTRIBUTING.md acknowledgment, change type, current behavior with issue links, new behavior details, and additional context. Update the description to follow the provided template, including all required sections such as confirming CONTRIBUTING.md was read and explicitly stating the change type.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix nimbus search' is vague and generic, using minimal specificity about what aspect of Nimbus search is being fixed. Consider a more specific title that explains the key fix, such as 'Use correct table name for page sections in Nimbus search mode'.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch charis/fix-nimbus-search

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@charislam charislam enabled auto-merge (squash) April 28, 2026 16:00
@charislam charislam merged commit d897c74 into master Apr 28, 2026
30 checks passed
@charislam charislam deleted the charis/fix-nimbus-search branch April 28, 2026 16:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Braintrust eval report

Assistant (master-1777392296)

Score Average Improvements Regressions
Completeness 88.9% (-7.000000000000001pp) - 4 🔴
Conciseness 30.6% (+5pp) 9 🟢 4 🔴
Correctness 73.3% (-20pp) - 2 🔴
Docs Faithfulness 60% (-12pp) 1 🟢 5 🔴
Goal Completion 83.3% (-5pp) 1 🟢 3 🔴
Knowledge Usage 100% (+0pp) - -
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 94.4% (-6pp) - 1 🔴
Tool Usage 78.6% (+5pp) 1 🟢 -
URL Validity 100% (+0pp) - -
Time_to_first_token 0tok (-0.01tok) 17 🟢 1 🔴
Llm_calls 11.07 (+0.28) 10 🟢 5 🔴
Tool_calls 4.15 (+0.28) 7 🟢 9 🔴
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 23486.72tok (-978.59tok) 7 🟢 11 🔴
Prompt_cached_tokens 7329.19tok (+815.41tok) 10 🟢 7 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 674.11tok (+49.91tok) 7 🟢 10 🔴
Completion_reasoning_tokens 144.85tok (+31.11tok) 7 🟢 11 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 24160.83tok (-928.69tok) 7 🟢 11 🔴
Estimated_cost 0$ (0$) 6 🟢 10 🔴
Duration 16.97s (+0.28s) 9 🟢 9 🔴
Llm_duration 12.72s (+1.7s) 7 🟢 11 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants