feat(storage): add keyboard shortcuts for storage screens#45837
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds configurable shortcut conflict handling, new storage-scoped shortcut registries, and wires keyboard shortcuts and ShortcutTooltip UI into Storage Buckets, Storage Explorer (header/selection), and Storage menu; also adds explorer refresh state and updates the shortcuts reference labels and tests. ChangesShortcut System Infrastructure
Storage Component Shortcuts
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
🎭 Playwright Test ResultsDetails
Skipped testsFeatures › auth-users.spec.ts › should show web3 users as enabled when the matching web3 provider is enabled |
Braintrust eval report
|
Summary
Adds keyboard shortcuts to the Storage section, mirroring the conventions already established for Auth Users and Database pages:
S, F/S, A/S, V/S, 3) active only insideStorageLayout.ShortcutTooltipwired into the relevant buttons so users can discover keybinds on hover.Test plan
Storage navigation chords
Active anywhere under
/project/<ref>/storage/*.SthenFSthenASthenVSthen3Files (bucket list) page
At
/project/<ref>/storage/files.Shift+FShift+NFthenCShift+RSthenCStorage Explorer (inside a bucket)
At
/project/<ref>/storage/files/buckets/<bucketId>.Shift+FShift+RIthenFSTORAGE_WRITEor at bucket root with no folderIthenNVthenCVthenLShift+DShift+MSTORAGE_WRITEgrantedMod+BackspaceMod= ⌘ on macOS /Ctrlon Win/Linux)EscapeEscapeEscapeTips while testing
Cmd+PS, F/I, F/V, C/F, C/S, C) won't fire while typing in an input — click out firstEscapedoes fire from inside the search field (closes the search)Cmd+/opens the full shortcuts referenceSummary by CodeRabbit