fix(www): fix contributors section overflow on mobile in careers page#45923
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for contributing to Supabase! ❤️ Our team will review your PR. A few tips for a smoother review process:
|
|
@AbhiVarde is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds the Tailwind ChangesCareers page contributors layout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Thanks @AbhiVarde for the PR! I actually noticed there are other pieces of the layout that are overflowing how they shouldn't.
For example the globe
and the black sphere at the bottom of the section.
The solution is to set overflow-hidden to the entire section. I inlined two suggestions to your pr that fix it, feel free to accept them or push the changes directly from your branch. I think the overflow-hidden got lost at some point...
Thanks!
2ce8820 to
25bfc06
Compare
|
done, applied both suggestions. thanks @fsansalvadore for the detailed review and catching the globe overflow too!! |
|
@AbhiVarde can't see the updated changes committed, might want to push again if you already did? |
pushed the fix now. applied overflow-hidden to the outer section wrapper as suggested. sorry for the confusion earlier! |
fsansalvadore
left a comment
There was a problem hiding this comment.
Looks good now, thanks @AbhiVarde ✌️
Braintrust eval reportEvals in progress... ⌛ |
Problem
The contributors section on /careers has a fixed
w-[1080px]container with no max-width constraint. On mobile viewports this causes horizontal overflow and breaks the page layout.Fix
Added
max-w-full overflow-hiddento the contributors wrapper so it caps at 1080px on large screens and fits within the viewport on smaller ones.File changed
apps/www/pages/careers.tsxScreenshots
Summary by CodeRabbit
Bug Fixes