chore: migrate auth Modal to Dialog#46392
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughFour Auth UI components migrate from the legacy Modal to modern Dialog and AlertDialog primitives, updating imports and JSX structure while maintaining form behavior, validation, and submit/cancel wiring. RedirectUrls additionally adopts a mutateAsync pattern for its delete mutation. ChangesAuth UI Modal to Dialog Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test ResultsDetails
Flaky testsFeatures › database.spec.ts › Database › Tables › CRUD operations and copy works as expected Skipped testsFeatures › auth-users.spec.ts › should show web3 users as enabled when the matching web3 provider is enabled |
Braintrust eval reportAssistant (bt::sp::custom::GitHub Actions-e1f8e343-7ee3-4763-ae7f-62d4550a6e7c-1779883903)
|
Problem
We still uses the deprecated
Modalfor:Test
Hard to test the JWT. I had to force its display by settings its
openprop totrueinapps/studio/components/interfaces/JwtSecrets/jwt-settings.tsxSolution
DialoginsteadSummary by CodeRabbit