Skip to content

fix: confirmation modal alert misses its title#46428

Merged
djhi merged 1 commit into
masterfrom
fix/confirmation-modal
May 27, 2026
Merged

fix: confirmation modal alert misses its title#46428
djhi merged 1 commit into
masterfrom
fix/confirmation-modal

Conversation

@djhi
Copy link
Copy Markdown
Contributor

@djhi djhi commented May 27, 2026

Backport ConfirmationModal from #46383

Summary by CodeRabbit

  • Bug Fixes
    • Fixed alert title display in confirmation modals to render correctly.

Review Change Stack

@djhi djhi requested a review from a team as a code owner May 27, 2026 12:56
@supabase
Copy link
Copy Markdown

supabase Bot commented May 27, 2026

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Ready Ready Preview, Comment May 27, 2026 1:04pm
docs Ready Ready Preview, Comment, Open in v0 May 27, 2026 1:04pm
studio-self-hosted Ready Ready Preview, Comment May 27, 2026 1:04pm
studio-staging Ready Ready Preview, Comment May 27, 2026 1:04pm
ui-library Ready Ready Preview, Comment May 27, 2026 1:04pm
zone-www-dot-com Ready Ready Preview, Comment, Open in v0 May 27, 2026 1:04pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
studio Ignored Ignored May 27, 2026 1:04pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: abe3b565-f4e8-4ec9-accf-d9d4d97566fb

📥 Commits

Reviewing files that changed from the base of the PR and between a6bfa04 and eb1f7e0.

📒 Files selected for processing (1)
  • packages/ui-patterns/src/Dialogs/ConfirmationModal.tsx

📝 Walkthrough

Walkthrough

ConfirmationModal corrects a prop key mismatch: the optional alert title in alertTitleProps is now passed to the Admonition component using the title property instead of label, aligning with Admonition's expected prop interface.

Changes

Alert title prop alignment

Layer / File(s) Summary
Alert title prop key correction
packages/ui-patterns/src/Dialogs/ConfirmationModal.tsx
alertTitleProps switches from { label: alert.title } to { title: alert.title } to match the Admonition component's expected prop contract.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • jordienr
  • CoolAssPuppy

Poem

🐰 A label became a title with care,
Props now match without despair,
Admonition smiles in the modal's lair,
One line fixed, the pattern's fair! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and does not follow the required template structure, missing key sections like detailed behavior explanation, new behavior description, and context. Expand the description to include: current behavior (what's broken), new behavior (how it's fixed), and reference the original issue #46383 more explicitly.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the specific bug fix: the confirmation modal's alert title was missing, and this PR corrects the property used in the alert title props from 'label' to 'title'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/confirmation-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@djhi djhi merged commit 4024984 into master May 27, 2026
32 checks passed
@djhi djhi deleted the fix/confirmation-modal branch May 27, 2026 14:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Braintrust eval report

Assistant (bt::sp::custom::GitHub Actions-e1f8e343-7ee3-4763-ae7f-62d4550a6e7c-1779892155)

Score Average Improvements Regressions
Completeness 94.4% (+12pp) 7 🟢 1 🔴
Conciseness 44.2% (-6pp) 6 🟢 11 🔴
Docs Faithfulness 65.4% (+2pp) 5 🟢 5 🔴
Goal Completion 76.1% (+11pp) 9 🟢 5 🔴
Knowledge Usage 96.7% (+10pp) 2 🟢 -
Correctness 68.2% (+4pp) 3 🟢 2 🔴
SQL Identifier Quoting 100% (+0pp) - -
SQL Validity 100% (+6pp) 1 🟢 -
Safety 90% (-10pp) - 1 🔴
Tool Usage 75% (+2pp) 1 🟢 -
Time_to_first_token 0tok (0tok) 18 🟢 7 🔴
Llm_calls 6.67 (-0.13) 7 🟢 11 🔴
Tool_calls 3.05 (-7.58) 14 🟢 6 🔴
Errors 0.03 (-0.03) 1 🟢 -
Llm_errors 0.01 (-0.01) 1 🟢 -
Tool_errors 0 (+0) - -
Prompt_tokens 25250.42tok (+3480.78tok) 7 🟢 15 🔴
Prompt_cached_tokens 6117.74tok (+137.85tok) 10 🟢 10 🔴
Prompt_cache_creation_tokens 0tok (+0tok) - -
Prompt_cache_creation_5m_tokens 0tok (+0tok) - -
Prompt_cache_creation_1h_tokens 0tok (+0tok) - -
Completion_tokens 540.32tok (-368.01tok) 14 🟢 12 🔴
Completion_reasoning_tokens 82.4tok (-11.29tok) 14 🟢 10 🔴
Completion_accepted_prediction_tokens 0tok (+0tok) - -
Completion_rejected_prediction_tokens 0tok (+0tok) - -
Completion_audio_tokens 0tok (+0tok) - -
Total_tokens 25790.74tok (+3112.77tok) 10 🟢 16 🔴
Estimated_cost 0$ (+0$) 7 🟢 14 🔴
Duration 12.73s (-3.36s) 18 🟢 8 🔴
Llm_duration 7.98s (-2.67s) 15 🟢 11 🔴

@7ttp 7ttp mentioned this pull request May 28, 2026
awaseem pushed a commit that referenced this pull request May 28, 2026
## TL;DR

fixes delete titles getting dropped in queue, cron job, hook, function,
and replication dialogs

## ref:
- closes #46446
- extends #46428

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Fixed alert title display in confirmation dialogs to ensure titles
render correctly with proper prop alignment.

<!-- review_stack_entry_start -->

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46447?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants