This repository was archived by the owner on Feb 19, 2025. It is now read-only.
feat: Accordian #213
Merged
feat: Accordian #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Woah this is awesome! |
MildTomato
suggested changes
Jun 1, 2021
Member
It's cool, leave it in 👍 |
Contributor
Author
|
@MildTomato glad you like it, I've fixed up those bits. How do you like to handle resolving conversation, PR author or reviewer? |
Member
@jonthomp I guess usually the reviewer. But feel free to resolve stuff if you are confident you've resolved it - it's all good 😄 |
Member
|
@jonthomp cool animation btw on these 👍 💯 |
Member
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behavior?
An Accordion component described in #102
Additional context
This also adds
classNametoIconContext, would you want that in a separate PR?