Skip to content

chore(s3vectors): remove bucket_name option from import foreign schema statement #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burmecia merged 1 commit into from
Nov 25, 2025
Merged

chore(s3vectors): remove bucket_name option from import foreign schema statement #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions docs/catalog/s3vectors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,8 @@ For example, using below SQL can automatically create foreign tables in the `s3_

```sql
-- create foreign table for each index from S3 Vector bucket
import foreign schema s3_vectors
from server s3_vectors_server into s3_vectors
options (
bucket_name 'my-vector-bucket'
);
import foreign schema "my-vector-bucket"
from server s3_vectors_server into s3_vectors;
```

### S3 Vector Tables
Expand Down Expand Up @@ -371,11 +368,8 @@ Import the foreign table:

```sql
-- Import all indexes from a vector bucket
import foreign schema s3_vectors
from server s3_vectors_server into s3_vectors
options (
bucket_name 'my-vector-bucket'
);
import foreign schema "my-vector-bucket"
from server s3_vectors_server into s3_vectors;

-- or, create the foreign table manually
create foreign table if not exists s3_vectors.embeddings (
Expand Down
9 changes: 5 additions & 4 deletions wrappers/src/fdw/s3vectors_fdw/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ This is a foreign data wrapper for [AWS S3 Vectors](https://aws.amazon.com/s3/fe

## Changelog

| Version | Date | Notes |
| ------- | ---------- | ---------------------------------------------------- |
| 0.1.1 | 2025-11-17 | Changed 'embd' type name to 's3vec' |
| 0.1.0 | 2025-09-14 | Initial version |
| Version | Date | Notes |
| ------- | ---------- | ---------------------------------------------------------- |
| 0.1.2 | 2025-11-19 | Removed 'bucket_name' option from 'import foreign schema' |
| 0.1.1 | 2025-11-17 | Changed 'embd' type name to 's3vec' |
| 0.1.0 | 2025-09-14 | Initial version |
4 changes: 2 additions & 2 deletions wrappers/src/fdw/s3vectors_fdw/s3vectors_fdw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use super::s3vec::S3Vec;
use super::{S3VectorsFdwError, S3VectorsFdwResult};

#[wrappers_fdw(
version = "0.1.1",
version = "0.1.2",
author = "Supabase",
website = "https://github.com/supabase/wrappers/tree/main/wrappers/src/fdw/s3vectors_fdw",
error_type = "S3VectorsFdwError"
Expand Down Expand Up @@ -437,7 +437,7 @@ impl ForeignDataWrapper<S3VectorsFdwError> for S3VectorsFdw {
&mut self,
import_stmt: ImportForeignSchemaStmt,
) -> S3VectorsFdwResult<Vec<String>> {
let bucket_name = require_option("bucket_name", &import_stmt.options)?;
let bucket_name = &import_stmt.remote_schema;
let mut next_token: Option<String> = None;
let mut ret: Vec<String> = Vec::new();

Expand Down
6 changes: 1 addition & 5 deletions wrappers/src/fdw/s3vectors_fdw/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@ mod tests {
c.update(r#"CREATE SCHEMA IF NOT EXISTS s3_vectors"#, None, &[])
.unwrap();
c.update(
r#"IMPORT FOREIGN SCHEMA "s3_vectors" FROM SERVER s3_vectors_server INTO s3_vectors
OPTIONS (
bucket_name 'my-vector-bucket'
)
"#,
r#"IMPORT FOREIGN SCHEMA "my-vector-bucket" FROM SERVER s3_vectors_server INTO s3_vectors"#,
None,
&[],
)
Expand Down
Loading