Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the package name extraction in the Wasm FDW release workflow and adds manual workflow dispatch capability. The current implementation incorrectly extracts the package name from the first package in the workspace metadata, which may not correspond to the actual FDW project being released.
Key Changes:
- Added workflow_dispatch trigger with manual tag input for on-demand releases
- Modified metadata extraction to filter for the specific project package using jq
- Updated package info extraction to reference the correct package object (removed array indexing)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
imor
approved these changes
Jan 8, 2026
DenisBessa
pushed a commit
to DenisBessa/wrappers
that referenced
this pull request
Mar 12, 2026
* ci: fix wasm fdw releaes package name * test workflow * test workflow * remove test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to fix the wrong package name in Wasm FDW release workflow.
What is the current behavior?
The current package name is hard-coded to extract from the first sub-project of the workspace.
What is the new behavior?
The package name should be extracted from the corresponding sub-project metadata json. A
jqcommand is added to search the package json in the workspace metadata json.Additional context
N/A