Fix off-by-one in merge queue position display - #752
Merged
Conversation
GitHub's GraphQL `MergeQueueEntry.position` is 1-based: the first entry in the queue reports position 1. The code assumed it was 0-based and added 1, so a PR that is actually first surfaced as "Position 2". Render the position as GitHub reports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub's GraphQL
MergeQueueEntry.positionis 1-based: the first entry in thequeue reports position 1. The code assumed it was 0-based and added 1, so a PR
that is actually first surfaced as "Position 2" across the sidebar, popover, and
notification. This renders the position exactly as GitHub reports it.
Type of change
ready)How was this tested?
Retargeted the merge-queue tests to real 1-based fixtures, keeping a genuine
second-place case (
position: 2-> "Position 2") that fails if the+1is everreintroduced. The batch-decode test now asserts the raw
position == 1with nodisplay arithmetic.
make checkpasses (format + lint)make testpassesChecklist
Closes #above.ready.