feat(release): add react to stable orchestrator#3221
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a03f2cf178
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| runInWorkspace(workspaceRoot, 'node', [ | ||
| join(workspaceRoot, 'scripts/npm-publish-package.cjs'), | ||
| '--package-dir', | ||
| 'packages/react', |
There was a problem hiding this comment.
When recovery runs from an older tagged snapshot (!tagAtHead in recoverPackageRelease), that temporary worktree only runs pnpm install; packages/react/dist is gitignored and is not present in the tag checkout. This adapter then invokes the generic publish helper directly, so an incomplete already-tagged React release can be recovered by publishing a tarball without the compiled dist/index.js/types instead of rebuilding first. Please mirror the MCP/superdoc recovery paths and build React when publishing from a snapshot worktree.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds react to the core chain after superdoc. react consumes `superdoc` in dependencies, so releasing them in order through the orchestrator means consumers never see a react release that pins to an older superdoc than what just shipped. - Adds `resumeReactPublish` adapter (uses generic `npm-publish-package.cjs` helper, idempotent against npm via dist-tag updates). - Adds react descriptor to the `core` chain. A superdoc failure now skips react (fail-closed within chain); a tools failure still does not. - `release-react.yml` stops auto-firing on stable; main pushes still publish prereleases. Stacked on #3204 (superdoc orchestrator).
caio-pizzol
force-pushed
the
release-orchestrator-pr3-react
branch
from
a03f2cf to
58a368a
Compare
2 participants
Adds react to the core chain after superdoc. react consumes `superdoc` in dependencies, so releasing them in order through the orchestrator means consumers never see a react release that pins to an older superdoc than what just shipped.
Stacked logically on the orchestrator series (#3201, #3204); both merged so this PR targets `main` directly.
Must stay the same: chain-independent semantics between tools and core (tools failure does not skip core, and vice versa); npm-verified docs promotion in promote-stable-docs.yml.
Verified: `node --test scripts/tests/release-local.test.mjs` → 23 pass, 2 fail (pre-existing on main, unrelated).