feat(release): add vscode-ext to stable orchestrator#3222
Merged
Conversation
caio-pizzol
force-pushed
the
release-orchestrator-pr3-react
branch
from
a03f2cf to
58a368a
Compare
caio-pizzol
force-pushed
the
release-orchestrator-pr4-vscode
branch
from
137709c to
d9dbab8
Compare
Completes the core chain: superdoc -> react -> vscode-ext. vscode-ext publishes to the VS Code Marketplace (not npm) and ships a .vsix asset on the GitHub release; the script's existing helpers already cover both, so this PR adds the descriptor, the resume adapter, and the workflow plumbing. - `resumeVscodeExtPublish` runs `pnpm run package` then `vsce publish --skip-duplicate`; idempotent against the marketplace. In a tagged snapshot it also runs `build:superdoc` first so esbuild can resolve the webview's `superdoc` and `superdoc/style.css` imports through packages/superdoc/dist (snapshot only ran `pnpm install`). - vscode-ext descriptor uses `vsCodeExtensionId` (no `npmPackages`), so `inspectPackageReleaseState` probes the marketplace, not npm. - release-stable.yml's orchestrator step gains `VSCE_PAT` env so vsce can authenticate. - release-vscode-ext.yml stops auto-firing on stable; main pushes still build .vsix attachments to the GitHub release. - Three remaining `pkg.name === 'vscode-ext'` branches in the script (`getExpectedReleaseAssets`, `isGitHubReleaseComplete`, `ensureGitHubRelease`) switched to `pkg.vsCodeExtensionId` capability checks for consistency with PR #3201's refactor pattern.
caio-pizzol
force-pushed
the
release-orchestrator-pr4-vscode
branch
from
d9dbab8 to
95f2164
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3221. Completes the core chain: superdoc → react → vscode-ext. vscode-ext publishes to the VS Code Marketplace (not npm) and attaches a .vsix to the GitHub release; the script's existing helpers already covered both, so this PR adds the descriptor, the resume adapter, and the workflow plumbing.
Must stay the same: vscode-ext's .vsix asset upload to the GitHub release (handled by `ensureGitHubReleaseAssets` during recovery); chain-independent fail-stop between tools and core.
Verified: `node --test scripts/tests/release-local.test.mjs` → 23 pass, 2 fail (pre-existing on main, unrelated).