Skip to content

fix(super-editor): verify comment selection feedback settles (IT-1278) #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 1 commit into from
Jul 13, 2026
Merged

fix(super-editor): verify comment selection feedback settles (IT-1278) #3816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/super-editor/src/editors/v1/extensions/comment/comments-plugin.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,30 @@ describe('CommentsPlugin state', () => {
expect(editor.emit).not.toHaveBeenCalled();
});

it('settles when the selected event is echoed back to the plugin', () => {
const { view, editor } = createPluginStateEnvironment();

editor.emit.mockImplementation((event, update) => {
if (event === 'commentsUpdate' && update.type === comments_module_events.SELECTED) {
setActiveComment(view, update.activeCommentId);
}
});

setActiveComment(view, 'comment-1');
setActiveComment(view, 'comment-2');
setActiveComment(view, 'comment-3');

vi.runAllTimers();

expect(editor.emit).toHaveBeenCalledTimes(1);
expect(editor.emit).toHaveBeenCalledWith('commentsUpdate', {
type: comments_module_events.SELECTED,
activeCommentId: 'comment-3',
});
expect(CommentsPluginKey.getState(view.state).activeThreadId).toBe('comment-3');
expect(vi.getTimerCount()).toBe(0);
});

it('does not emit when the editor is destroyed before a deferred notification runs', () => {
const { view, editor } = createPluginStateEnvironment();

Expand Down
Loading