Skip to content

docs(contracts): apply compat-fallback taxonomy to resolved-layout fragmentIndex (SD-2923) - #3112

Merged
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/SD-2923-legacy-resolved-layout
May 4, 2026
Merged

docs(contracts): apply compat-fallback taxonomy to resolved-layout fragmentIndex (SD-2923)#3112
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/SD-2923-legacy-resolved-layout

Conversation

@caio-pizzol

Copy link
Copy Markdown
Contributor

First in-the-wild application of the loaded-term taxonomy added in #3103. The four fragmentIndex fields on ResolvedFragmentItem / Table / Image / Drawing previously used the word "legacy" with three different shades across the layout-engine package: older path, current fallback, and removed code, all conflated. In this file, "legacy" actually meant the current load-bearing fallback the painter uses to read inner content from Fragment until ResolvedFragmentItem carries full content directly.

Apply the compat-fallback term uniformly: each fragmentIndex field now carries an AIDEV-NOTE: compat-fallback anchor naming what triggers the fallback (ResolvedFragmentItem missing content) and the retirement condition (paint items become self-describing). Drop the "and used for legacy content lookup" tail from blockId and rewrite the type-level docstring to point at the per-field anchor instead of "legacy fragment renderers".

No behavior change. The point is to make the taxonomy a convention in code rather than just policy on paper.

Related: SD-2923 (comment hygiene umbrella).

…agmentIndex (SD-2923)

The four `fragmentIndex` fields on ResolvedFragmentItem / Table / Image /
Drawing previously used the word "legacy" with three different shades
across the layout-engine - older path, current fallback, and removed
code - all conflated. In this file, "legacy" actually means the *current
load-bearing fallback* the painter uses to read inner content from
Fragment until ResolvedFragmentItem carries full content directly.

Apply the compat-fallback term from comment-policy.md uniformly: each
fragmentIndex field now carries an AIDEV-NOTE: compat-fallback anchor
naming what triggers the fallback (ResolvedFragmentItem missing
content) and the retirement condition (paint items become
self-describing). Drop "legacy content lookup" trailer from
ResolvedFragmentItem.blockId and rewrite the type-level docstring to
reference the per-field anchor instead of "legacy fragment renderers".

This is the first in-the-wild use of the loaded-term taxonomy added in
#3103. No behavior change.
@caio-pizzol
caio-pizzol requested a review from a team as a code owner May 4, 2026 14:30
@linear

linear Bot commented May 4, 2026

Copy link
Copy Markdown

@caio-pizzol
caio-pizzol merged commit 2a72c82 into main May 4, 2026
70 checks passed
@caio-pizzol
caio-pizzol deleted the caio-pizzol/SD-2923-legacy-resolved-layout branch May 4, 2026 14:38
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.38

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.80

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in vscode-ext v2.3.0-next.82

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc v1.30.0-next.39

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-cli v0.8.0-next.56

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-sdk v1.8.0-next.41

@superdoc-bot

superdoc-bot Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-cli v0.9.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc v1.32.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/mcp v0.4.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in @superdoc-dev/react v1.3.0

The release is available on GitHub release

@superdoc-bot

superdoc-bot Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in vscode-ext v2.4.0

@superdoc-bot

superdoc-bot Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in superdoc-sdk v1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants