feat: upgrade w:hyperlink import/export to v3 (HAR-10497) - #942
Merged
Conversation
added 4 commits
September 11, 2025 16:20
The idea is that we use `target='_blank'` as a default only when rendering the link without assigning that value to the node attribute. The goal is to not overwrite the target value when the document is imported.
The goal is to allow the functions to call other methods in the node translator from their implementation.
luccas-harbour
force-pushed
the
feature/har-10497-2-handler-for-whyperlink
branch
2 times, most recently
from
September 11, 2025 20:32
cdf4015 to
7a3681d
Compare
luccas-harbour
requested review from
VladaHarbour,
artem-harbour and
harbournick
September 11, 2025 20:42
luccas-harbour
marked this pull request as ready for review
September 11, 2025 20:42
luccas-harbour
marked this pull request as draft
September 11, 2025 20:43
added 11 commits
September 11, 2025 18:33
luccas-harbour
force-pushed
the
feature/har-10497-2-handler-for-whyperlink
branch
from
September 11, 2025 21:33
7a3681d to
5eddb01
Compare
luccas-harbour
changed the title
luccas-harbour
marked this pull request as ready for review
September 11, 2025 21:44
harbournick
approved these changes
Sep 15, 2025
harbournick
left a comment
harbournick
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - really great contributions to the import/export v3 upgrades here - above and beyond! Much appreciated 🎉
harbournick
enabled auto-merge (squash)
September 15, 2025 17:49
Collaborator
|
🎉 This PR is included in version 0.19.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
harbournick
pushed a commit
that referenced
this pull request
Sep 17, 2025
# [0.19.0](v0.18.1...v0.19.0) (2025-09-17) ### Bug Fixes * content-block node ext wrong schema and rendering rules ([#965](#965)) ([#966](#966)) ([f037f44](f037f44)) * full repo test on npm test or npm run test ([3ede3e0](3ede3e0)) * move undo/redo from collaboration to history ([#956](#956)) ([21299f8](21299f8)) ### Features * add document.xml.rels validator ([#881](#881)) ([ac7f2a9](ac7f2a9)) * add v3 translator for w:tr and w:trPr elements (HAR-10480) ([#953](#953)) ([ce4eb8d](ce4eb8d)) * support Blob type in fileSource and document properties ([#967](#967)) ([4260c51](4260c51)) * upgrade w:hyperlink import/export to v3 (HAR-10497) ([#942](#942)) ([0f98a8e](0f98a8e))
Collaborator
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
superdoc-bot Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
* feat(catalog): add permanent slugs for demos and examples Moving a demo or example directory breaks every GitHub link already published, because GitHub only leaves redirects behind for repository renames, not for paths inside a repository. Today the only fix is a stub README left at the old path, and seven of those already exist. This adds a `slug` field to catalog entries: the permanent public name a demo is reachable by at go.superdoc.dev, independent of where its source currently lives. It stays separate from `id` because `id` is the internal catalog key and should stay free to follow section renames, while a public slug cannot move without breaking links we do not control. Slugs are opt-in, so nothing is published until it has earned a permanent name, and 26 entries are named here to start. The validator rejects duplicates, non-kebab-case names, names that would shadow a service route, and slugs on entries we have deliberately withdrawn. The service that serves those URLs is superdoc/linkkeeper, a separate project. It reads these manifests directly, so publishing an example is just the slug edit and there is no second list to keep in sync. The workflow added here only tells it when the catalog changed, and it lives in the public repo rather than in Orbit's export pipeline: the export pushes straight to public main, so by then the manifests are already public and the SHA is the exported one. The catalog had no CI gate on this branch, so metadata validation now runs in its own fast workflow rather than inside the demo build. * docs(superdoc): link examples through their stable URLs Points the documentation at go.superdoc.dev for the 17 links whose targets now have a published slug. These survive the next reorganization of the examples tree; the raw GitHub paths they replace would not. Links to examples that do not have a slug yet are left alone rather than invented, so nothing here points at a URL that does not resolve. They can move over as those examples are named. Nothing else changes: same destinations, one redirect in front of them. Ported-From-Source-Repo: superdoc/orbit Ported-From-Source-Commit: 258268f8ec8ab14bb439a51ed9ec5da03279e726 Ported-Public-Prefix: superdoc/public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyperlinkduring import