fix(spec): correct PDF search result pages - #20
Conversation
Co-authored-by: Ben Lewis <blewis@hirundo.io>
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: Ben Lewis <blewis@hirundo.io>
Code Review by Qodo
🔴 High 1.
|
There was a problem hiding this comment.
All reported issues were addressed across 20 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: Ben Lewis <blewis@hirundo.io>
There was a problem hiding this comment.
All reported issues were addressed across 13 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Co-authored-by: Ben Lewis <blewis@hirundo.io>
Co-authored-by: Ben Lewis <blewis@hirundo.io>
What was wrong
Search results could open the wrong PDF page because:
Fix
Ben's example, Part 1 §17.3.1.12, now returns printed pages 219, 221, and 223. Page 219 opens PDF sheet 229.
Supersedes #12 after changes to
main. Based on @benglewis's report and original work; Ben is credited as a co-author.Tested
bun run testbun run pdf:testbun run typecheckbun run lintbun run buildPreview: https://caio-fix-pdf-navigation.ooxml-dev.pages.dev/spec?section=17.3.1.12&part=1