logging: log equiv. of LOG_LEVEL=debug to files in ~/.fly/logs - #2536
Merged
Conversation
dangra
reviewed
Jul 5, 2023
dangra
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
To make troubleshooting easier and issues more reproducible, we'll keep logs for the last 10 (this is a totally arbitrary number) runs of flyctl. These logs are the equivalent of
LOG_LEVEL=debug, although they won't contain the actual output - only the debug logs.How:
A lot of cleanup around logging and the
terminalpackage. We had like four reimplementations of this logging system scattered around flyctl lmao, this consolidates most of it.Related to: internal discussion
Documentation
Sorry about the mega-commit! I kind of dug myself into a hole, and had to rewrite things to get out of it - in the process I just totally lost any hope of a reasonable commit history.