Ensure canary/green machines get their health checked - #4952
Merged
Conversation
lubien
force-pushed
the
fix/bluegreen-canary-skiplaunck-healthcheck
branch
from
August 5, 2026 13:22
06e9fe0 to
b7a732e
Compare
lubien
marked this pull request as ready for review
August 5, 2026 13:22
lubien
changed the title
lubien
force-pushed
the
fix/bluegreen-canary-skiplaunck-healthcheck
branch
from
August 5, 2026 13:28
b7a732e to
dc83e1c
Compare
dangra
reviewed
Aug 5, 2026
dangra
left a comment
dangra
left a comment
Member
There was a problem hiding this comment.
what is the rationale to start all green instances? shouldn't it be enough (and faster) if it mimics the started/stopped instances? At minimum, it could ensure at least one is started and passing checks from each process group.
…y-skiplaunck-healthcheck
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why: fix green and canary machines being considered ready if they're stopped
How: ensure they start so we can actually see their healthchecks
Related to: internal forum post
Documentation