Use client-signals Operator() for metrics classification#5000
Merged
Conversation
Bump client-signals to v0.4.2 and simplify OperatorFromSignals to delegate to the library's Operator() method instead of reimplementing the precedence logic locally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dangra
approved these changes
Jul 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates flyctl’s metrics operator classification by upgrading github.com/superfly/client-signals/go and switching OperatorFromSignals to rely on the library’s new Signals.Operator() precedence logic.
Changes:
- Bump
client-signalsdependency fromv0.3.0tov0.4.2. - Simplify
OperatorFromSignalsto useSignals.Operator()instead of locally re-encoding precedence. - Update module sums to reflect the dependency upgrade.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/metrics/helpers.go | Uses Signals.Operator() for operator classification in deploy/launch metrics payloads. |
| go.mod | Upgrades github.com/superfly/client-signals/go to v0.4.2. |
| go.sum | Adds sums for the upgraded client-signals versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client-signalsto v0.4.2OperatorFromSignalsto use the library's newOperator()method instead of reimplementing the precedence logicRelated PRs
Operator()method (merged)Test plan
go buildpassesoperatorandagentNamevalues🤖 Generated with Claude Code