Split slow preflight test groups - #5045
Merged
Merged
Conversation
…eflight-groups # Conflicts: # .github/workflows/preflight.yml # scripts/preflight.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDeployin a dedicateddeploy-fixturesmatrix jobTestPostgres_FlexFailoverin a dedicatedpostgres-flex-failovermatrix jobgo testinvocation with an argument array so optional flags are passed safelyWhy
Recent scheduled preflight runs repeatedly hit the 15-minute package timeout in the deploy and postgres groups. The slow tests start after several other integration tests have already consumed much of that shared budget; postgres flex failover can also spend several minutes retrying cluster creation.
Giving those tests independent jobs preserves the existing timeout as a safety cap while preventing unrelated tests in the same package from exhausting their runtime.
Example failure: https://github.com/superfly/flyctl/actions/runs/30874868531
Validation
bash -n scripts/preflight.sh.github/workflows/preflight.yml-shortmode)go test -tags=integration -run '^$' ./test/preflight/...