fix(encode-db): write valid snapshots safely - #90
Merged
corylanou merged 3 commits intoAug 12, 2026
Merged
Conversation
Use the current in-memory format version and atomically replace output files. Reject aliased input/output paths and preserve existing output on failure. Add command-level round-trip and safety regression coverage.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af5b0aadb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep CreateTemp's restrictive mode for new snapshots so chmod cannot bypass umask protections. Restore the recorded mode only when replacing an existing destination. Add coverage for secure new files and existing mode preservation.
benbjohnson
approved these changes
Aug 12, 2026
corylanou
deleted the
issue-81-encode-db-writes-a-version-1-header-the-library-itself-rejec
branch
August 12, 2026 16:13
corylanou
added a commit
that referenced
this pull request
Aug 12, 2026
The command test arrived with #90 while this branch was in flight. On main ltx.Version is 3 so it passed; here encryption raises the constant to 4 while unencrypted output correctly stays v3.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Fixes #81
Fixes #87