Restore optional Jason.Encoder support - #9
Merged
Merged
Conversation
v0.2.21 moved struct encoding to the built-in JSON.Encoder protocol, dropping the Jason.Encoder implementations and breaking downstream callers of Jason.encode!/1. Re-add Jason.Encoder impls for all caveat structs, resource set caveats, and Macfly.Action, guarded by Code.ensure_loaded?(Jason) so they only compile when the optional :jason dependency is present. - json_round_trip/1 test helper now asserts Jason output matches the built-in JSON output, keeping the two protocol impls in sync - add CHANGELOG.md and bump version to 0.2.22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.2.21 moved struct encoding to the built-in JSON.Encoder protocol, dropping the Jason.Encoder implementations and breaking downstream callers of Jason.encode!/1. Re-add Jason.Encoder impls for all caveat structs, resource set caveats, and Macfly.Action, guarded by Code.ensure_loaded?(Jason) so they only compile when the optional :jason dependency is present.