Correct MCP tool reference and close migration coverage gaps - #1
Merged
Conversation
- tools.md: rename the Access column to Risk and explain that the server annotates every non-GET tool with destructiveHint, so create_sprite, exec, checkpoint_create, service_create, and service_start arrive marked destructive despite being ordinary writes. - tools.md: document the optional parameters the skills already tell agents to use -- wait_for_capacity, pagination tokens, exec_kill signal/timeout, service log and duration options, and the policy rule shape. - safety.md: state that policy_network_update replaces rather than merges the rule set, and require a policy_network_get read-back before writing. - Add references/deployment.md with the sync flow and do-not-sync boundaries that were dropped when the Antigravity package was folded in. - migration-coverage.md and README: account for every adjacent client package, correct and complete the compatible-client list, and note that the spec is still a Working Draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to a review of this package against the Agent Plugins 1.0.0 spec and the adjacent client-specific Sprites packages.
The manifests themselves were already conformant —
plugin.jsonandmcp.jsonvalidate against the published 1.0.0 schemas, all nine skills satisfy the Agent Skills spec, and skill discovery relies only on immediate children ofskills/. These changes fix inaccuracies in the reference content and restore guidance that was dropped during consolidation.Accuracy
tools.mdrisk classification. TheAccesscolumn used three tiers, but the server derives MCP annotations from HTTP method (readOnlyHintfor GET,destructiveHintfor everything else). That meanscreate_sprite,exec,checkpoint_create,service_create, andservice_startall arrive annotated destructive, contradicting theirwriterows — and the public server README uses only read/write, so the table matched neither source. Renamed toRiskand added a section explaining the mismatch so an agent does not treat it as a bug or usedestructiveHintalone to decide whether to ask permission.Missing parameters.
tools.mdis what the core skill points to "when parameter details matter," but it omitted several the skills already tell agents to use:wait_for_capacity(sprites-new says "wait for usable state"),max_results/continuation_token(sprites-list says "paginate"),exec_killsignal/timeout,service_logslines/duration, start/stop duration, and therulesarray shape. Also documents theexecenvKEY=VALUErepeatable form, and thatservice_create.cmdis a single string with arguments inargs— unlikeexec's repeatablecmd.Network policy semantics.
policy_network_updatereplaces the entire rule set rather than merging.safety.mdonly asked for confirmation before widening policy, which misses that a narrowing-intent update silently drops unrelated rules. Now requires apolicy_network_getread-back and confirmation of the complete intended set.Coverage
references/deployment.md(new). The Antigravity package carried a deployment reference whose sync-exclusion list (.git/, dependency and build caches,.envand credential stores, large generated artifacts) had no equivalent here —compute.mdandfiles.mdcover how to transfer code but never what to leave behind. Restored and expanded with prefer-clone-over-copy guidance, run-time credentials instead of written secrets, and post-sync verification. Linked fromSKILL.mdandcompute.md.Migration doc completeness. The artifact table reads as exhaustive but omitted one adjacent client package entirely and silently dropped the Antigravity deployment reference. Both are now mapped, including where the guard-script warnings and checkpoint-command heuristics landed.
Compatible-client list. Corrected to the current five (ChatGPT and Codex, VS Code, Kiro, GitHub Copilot, Cursor), noting all five support Streamable HTTP so the single
mcp.jsonentry reaches every one. The "keep the existing package" caveat now names all three clients that are not on the list. README also notes the spec is still a Working Draft.Validation
python3 scripts/check_repository.pyclean across 27 files;python3 -m unittest discover -s tests7/7 passing. No network calls added.