Skip to content

Use sprites.app in sprite url examples, not sprites.dev, which is confusing#186

Merged
clouvet merged 2 commits into
mainfrom
fix-wrong-example-domain
Jun 25, 2026
Merged

Use sprites.app in sprite url examples, not sprites.dev, which is confusing#186
clouvet merged 2 commits into
mainfrom
fix-wrong-example-domain

Conversation

@clouvet

@clouvet clouvet commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Preview Deployment

Name URL
Preview https://pr-186-superfly-sprites-docs.fly.dev

Commit: 33b77cf

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ Tests success

Ran against: https://pr-186-superfly-sprites-docs.fly.dev

@github-actions

Copy link
Copy Markdown
Contributor

Lighthouse Results

⚠️ Lighthouse failed to collect results. This may be due to the preview deployment not being ready.

Comment thread src/content/docs/cli/commands.mdx
Comment thread src/content/docs/concepts/networking.mdx
@kcmartin

kcmartin commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

The published change here (commands.mdx) is correct, but since both edited lines sit inside the AUTO-GENERATED-CONTENT block, which is regenerated from the CLI help in superfly/sprite-env (client/docs/url.md). The companion PR superfly/sprite-env#499 fixes the URL-format source line but not the curl example, so on the next docs regen the curl line will revert to sprites.dev. Worth adding the url.md:33 fix in #499 alongside this so the change sticks.

@kcmartin kcmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some notes and suggestions

@kcmartin kcmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@clouvet clouvet merged commit 1051e0f into main Jun 25, 2026
4 of 5 checks passed
@clouvet clouvet deleted the fix-wrong-example-domain branch June 25, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants