Skip to content

Conversation

@supermario
Copy link
Owner

@supermario supermario commented Sep 19, 2023

This work was prompted by the new discovery of various crashes in the current macos-arm64 build which used GHC 9.0.2 (which also required the use of llvm@12).

Building with GHC 9.4 appears to have resolved the issue with the need for llvm, however due to the Word8 changes (donated by @robinheghan with thanks to his work on Gren), @lydell discovered a regression in the following code that worked previously but no longer does:

module Main exposing (main)

import Html

åäö = "test"

main = Html.text åäö

Once we resolve this bug we should be able to cut a new macos-arm64 release into the @lydell/elm npm package after wider testing confirms it's working okay on M* macs.

Todo

Repository owner deleted a comment from github-actions bot Sep 19, 2023
@lydell
Copy link

lydell commented Sep 19, 2023

FYI I tested applying the (at the time, 3) commits of this branch that aren’t in master onto elm/compiler@c9aefb6 which is the release commit of https://github.com/elm/compiler/releases/tag/0.19.1! It went well!

Good to know once we’re ready to compile a new macOS ARM binary for @lydell/elm and elm-tooling.

@supermario
Copy link
Owner Author

Regression appears to be fixed now, with thanks to @robinheghan , @jxxcarlson , @avh4 and @lydell for repro & investigation 🙌

supermario added a commit to lamdera/compiler that referenced this pull request Sep 21, 2023
@supermario supermario merged commit 9017c4a into distribution Sep 22, 2023
@supermario supermario deleted the distribution-ghc-9.4 branch September 22, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants