feat(web): configure Company Brain reasoning effort#1307
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 9824f0c | Jul 18 2026, 07:16 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 9824f0c | Commit Preview URL Branch Preview URL |
Jul 18 2026, 07:18 PM |
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Reviewed the UI changes against the existing Company Brain settings patterns. No blocking issues found. Checked that the controls use the same dark Nova styling primitives, degrade safely when effort choices are absent from older backend responses, keep non-admins disabled, and send a partial PATCH only for changed model/effort fields. Local validation:
|
|
Claude finished @MaheshtheDev's task in 1m 17s —— View job Reviewing PR #1307
Overview: Adds preset-based reasoning effort controls (Fastest/Balanced/Most thorough) with an Advanced panel for fine-grained model and effort configuration per role. Issues found: None — this looks good to ship. The implementation correctly:
Score: 10/10 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Adds reasoning effort controls (Low/Medium/High/Extra high) for Main, Triage, and Research models with proper state management and graceful backend degradation.
Issues found: None — this looks good to ship.
The implementation correctly:
- Handles optional effort values with proper fallback chain (
draft → resolved → defaults → "") - Prevents deselection issues via
if (!value) returnin ToggleGroup's onValueChange - Only shows effort controls when the backend provides
effortOptions - Builds minimal PATCH payloads with only changed values
- Shows appropriate warning for xhigh on Grok/GPT providers
Score: 10/10
a3ffd13 to
ea883ae
Compare
f9f24ef to
20e585c
Compare
ea883ae to
61b86cc
Compare
|
Note Production impact unlikely. Checked the reasoning-effort UI changes against supermemory-app; the PATCH contract is additive (new optional effort keys on the existing partial endpoint), no bindings/routes/error handling were removed, and the worker currently shows 0 errors on its low traffic. Polylane analysed |
Merge activity
|
## Stack context Stacks on #1306, which moves Company Brain settings into the revamped Configure page. Backend contract and runtime support: supermemoryai/mono#2581. The UI safely hides any effort controls omitted by an older backend response. ## What changed - Adds independent Low, Medium, High, and Extra high reasoning controls for Main, Triage, and Research. - Saves model and reasoning edits together through the existing partial PATCH. - Keeps controls visible but disabled for non-admin members. - Explains that Extra high maps to High for Grok and GPT providers. ## Validation - `bunx biome check apps/web/hooks/use-brain-models.ts apps/web/components/settings/company-brain-models.tsx` - `bun run build` in `apps/web` - `git diff --check` The standalone web TypeScript command still reports pre-existing unrelated errors outside these files. --- **Session Details** - Session: [View Session](https://supermemory.us1.vorflux.com/agent-sessions/1c4f3ec7-a536-4105-bbe7-8b19e61f245f) - Requested by: Sreeram Sreedhar (sreeram@supermemory.com) - Address comments on this PR. Add `(aside)` to your comment to have me ignore it.
61b86cc to
9824f0c
Compare
2 participants
Stack context
Stacks on #1306, which moves Company Brain settings into the revamped Configure page.
Backend contract and runtime support: supermemoryai/mono#2581. The UI safely hides any effort controls omitted by an older backend response.
What changed
Validation
bunx biome check apps/web/hooks/use-brain-models.ts apps/web/components/settings/company-brain-models.tsxbun run buildinapps/webgit diff --checkThe standalone web TypeScript command still reports pre-existing unrelated errors outside these files.
Session Details
(aside)to your comment to have me ignore it.