Skip to content

feat(web): Company Brain proactivity settings UI - #1374

Merged
graphite-app[bot] merged 1 commit into
mainfrom
brain-proactivity-settings-ui
Jul 29, 2026
Merged

feat(web): Company Brain proactivity settings UI#1374
graphite-app[bot] merged 1 commit into
mainfrom
brain-proactivity-settings-ui

Conversation

@MaheshtheDev

@MaheshtheDev MaheshtheDev commented Jul 29, 2026

Copy link
Copy Markdown
Member

Part of ENG-1135

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 1034e33 Commit Preview URL

Branch Preview URL
Jul 30 2026, 08:45 AM

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 1034e33 Jul 30 2026, 08:44 AM

@linear-code

linear-code Bot commented Jul 29, 2026

Copy link
Copy Markdown

ENG-1135

@MaheshtheDev
MaheshtheDev marked this pull request as ready for review July 29, 2026 18:57
@claude

claude Bot commented Jul 29, 2026

Copy link
Copy Markdown

Claude finished @MaheshtheDev's task in 48s —— View job


Review Complete

  • Load MCP tools
  • Fetch PR diff and existing review comments
  • Analyze changes for bugs, security issues, and logic errors
  • Post review summary

Overview: Adds a new "Proactivity" settings section to the Company Brain configuration, allowing admins to control when the brain proactively joins Slack conversations vs. staying quiet, with per-channel overrides.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Proper loading/error states with appropriate UI feedback
  • Admin access control enforced both in UI (disabled prop) and backend (403 handling)
  • React Query used correctly with proper cache invalidation via setQueryData
  • Error handling with user-friendly toast notifications
  • No security concerns — credentials properly included, no XSS vectors (channel names rendered as text)
  • The icon type generalization from typeof Blocks to React.ComponentType<{ className?: string }> is a clean way to support custom SVG components

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a new "Proactivity" settings section to the Company Brain configuration, allowing admins to control when the brain proactively joins Slack conversations vs. staying quiet, with per-channel overrides.

Issues found: None — this looks good to ship.

The implementation is solid:

  • Proper loading/error states with appropriate UI feedback
  • Admin access control enforced both in UI (disabled prop) and backend (403 handling)
  • React Query used correctly with proper cache invalidation via setQueryData
  • Error handling with user-friendly toast notifications
  • No security concerns — credentials properly included, no XSS vectors (channel names rendered as text)
  • The icon type generalization from typeof Blocks to React.ComponentType<{ className?: string }> is a clean way to support custom SVG components

Score: 10/10

@MaheshtheDev
MaheshtheDev force-pushed the brain-proactivity-settings-ui branch from 2bfa37e to acc65a2 Compare July 29, 2026 21:44
@graphite-app

graphite-app Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merge activity

Comment on lines +56 to +57
if (res.status === 403)
throw new Error("Only admins can change these settings.")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule states 'Include any supporting data as the cause argument instead of inlining into the string' when throwing errors. On line 57, throw new Error("Only admins can change these settings.") is thrown after a 403 response, but the response object (res) which is the supporting data/cause is not passed as the cause argument. It should be:

throw new Error("Only admins can change these settings.", { cause: res });
Suggested change
if (res.status === 403)
throw new Error("Only admins can change these settings.")
if (res.status === 403)
throw new Error("Only admins can change these settings.", { cause: res })

Spotted by Graphite (based on custom rule: TypeScript style guide (Google))

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

message?: string
error?: string
}
throw new Error(b.message ?? b.error ?? "Failed to save settings")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule states 'Include any supporting data as the cause argument instead of inlining into the string' when throwing errors. On line 63, throw new Error(b.message ?? b.error ?? "Failed to save settings") inlines the error message from the response body directly into the error string. The response body b (which contains the supporting data) should be passed as the cause argument:

throw new Error("Failed to save settings", { cause: b });
Suggested change
throw new Error(b.message ?? b.error ?? "Failed to save settings")
throw new Error("Failed to save settings", { cause: b })

Spotted by Graphite (based on custom rule: TypeScript style guide (Google))

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@graphite-app
graphite-app Bot force-pushed the brain-proactivity-settings-ui branch from acc65a2 to 1034e33 Compare July 29, 2026 21:47
@graphite-app
graphite-app Bot merged commit 1034e33 into main Jul 29, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants